Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing workflow changes and commit SHAs #9

Closed
wants to merge 43 commits into from
Closed

Conversation

Anirban166
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Apr 12, 2024

Comparison Plot

Generated via commit d80b6d7

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 6 seconds

Time taken to run atime::atime_pkg on the tests: 4 minutes and 10 seconds

@tdhock
Copy link

tdhock commented Apr 18, 2024

I see that Fast is constant time and others are linear (same as slow), is that normal? I was expecting all to be linear and others to be same as fast (not slow).

@Anirban166
Copy link
Owner Author

I see that Fast is constant time and others are linear (same as slow), is that normal? I was expecting all to be linear and others to be same as fast (not slow).

It's because the current master branch is indeed slow since Rdatatable#5427 hasn't been merged yet - once that is done, I'd expect at least 'Base', 'merge-base', and 'CRAN' to be aligned with 'Fast' (also 'HEAD' if the triggering PR does not affect or degrade performance for that test)

.ci/atime/tests.R Outdated Show resolved Hide resolved
.ci/atime/tests.R Outdated Show resolved Hide resolved
@Anirban166 Anirban166 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants