-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MFA authenitcation support with prompt for confirmation code #13
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! Can you give me some instructions on how to test it? |
Sure! you need to create a user pool and require MFA, see attached screenshot. SNS should be enabled as well. Once the pool is set-up, every successful user/password login attempt will emit an SMS confirmation code to the user. The CLI will halt and prompt for the code. If a correct code is entered it will complete the process. I would test all positive and negative options, e.g.:
|
Awesome! I'll give it a try this weekend. |
@talyaniv I'm trying to test this. Can you tell me how to create a user that needs MFA? Currently we use this to create a user:
|
@jayair This is the complete sign-in flow for MFA enforced user: Sign up:
The expected response:
After the confirmation code 123456 received at my device I call:
No response payload should be expected on this one. Now, when the user is confirmed, this is how the sign-in flow looks like
The expected response:
You should be receiving the auth code at your device and complete the auth sign-in flow by confirming it:
And now the final response looks like a standard sign-in response:
|
Also see my previous reply with screenshot. Make sure you mark the MFA related checkboxes and options. |
one suggestion. Could we have a new option, such as |
@ozbillwang What would this option do? |
Since this is a command line, I can run it with shell scripting with new generated MFA token every time. |
Also see updated package.json with latest aws-sdk version