Add generageStatsFiles flag
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@dror-weiss Thanks for this! Any idea why the tests are failing? |
…to feature/generate-stats-files * origin/feature/generate-stats-files: # Conflicts: # index.js
|
@jayair, I removed a timeout on my test that I forgot to remove, but that wasn't it. I tried to reproduce those errors but I wasn't able to pinpoint the reason, but after I merged from your current |
|
Great! Thanks @dror-weiss. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227.
Sets up the
generateStatsFilesflag, which spits out bundle_stats.json and bundle_stats.html stats files to the.webpackdirectory. This can then be used in other tools to analyze the bundle size of the deployed lambda/service.Reference:
generateStatsFiles: false(stats files are not being generated and not being bundled)generateStatsFiles: true(stats files are being generated under.webpackand not being bundled)Special thanks to @krishnagopinath which started this fix.