Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop non-working concat text plugin, resolve #341 #343

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

fancywriter
Copy link
Contributor

No description provided.

@jayair
Copy link
Member

jayair commented Dec 8, 2022

Can you link to the related GH issue so I can see why we want to do this?

@fancywriter
Copy link
Contributor Author

@jayair the link is already here #341

@curtdept
Copy link

curtdept commented Jan 4, 2023

@jayair nudge

@jayair
Copy link
Member

jayair commented Jan 4, 2023

Thanks! But in this case we are dropping this feature right? That would be a breaking change. Is there an update to the plugin or is there a new plugin we can use to do this?

@curtdept
Copy link

curtdept commented Jan 4, 2023

Thanks! But in this case we are dropping this feature right? That would be a breaking change. Is there an update to the plugin or is there a new plugin we can use to do this?

@jayari I searched around for a bit, this repo is totally archived now and there is no obvious successor. I even searched through the forks hoping someone took it up.

https://github.com/merkle-open/webpack-concat-text-plugin

@mrjono1
Copy link

mrjono1 commented Jan 9, 2023

Without this upgrade we cannot keep up to date with node 18 so maybe a breaking change is ok, and if someone can find something to replace concat-text-webpack-plugin it can be added back later?
I would guess most users wouldn't be using the features of concat-text-webpack-plugin ??

@jayair
Copy link
Member

jayair commented Jan 9, 2023

Yeah we might have to just go with that.

@jayair jayair added the breaking This is a breaking change label Jan 9, 2023
@jayair jayair merged commit 15d6902 into AnomalyInnovations:master Jan 9, 2023
@jayair
Copy link
Member

jayair commented Jan 9, 2023

Published https://github.com/AnomalyInnovations/serverless-bundle/releases/tag/v6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants