Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional forceExclude of aws-sdk based on runtime version #366

Merged
merged 17 commits into from
Nov 30, 2023

Conversation

cnuss
Copy link
Contributor

@cnuss cnuss commented Nov 24, 2023

On nodejs18.x and greater, aws-sdk is no longer included and should be conditionally excluded based on the runtime version, instead of being a hardcoded exclude.

Fixes:

Ref: https://stackoverflow.com/a/74792625

@cnuss
Copy link
Contributor Author

cnuss commented Nov 24, 2023

cc @jayair could i get some 👀 on this please? thank you!

cc @warrickhill this is a similar fix to #354 but includes tests 😄, which I didn't actually see your pre-existing PR until after I did this work.

@cnuss
Copy link
Contributor Author

cnuss commented Nov 24, 2023

Ok I tweaked this a bit so that the "default config" doesn't hardcode aws-sdk. It's now programatically added in the event the runtime is less than nodejs18.x, which should be more future proof!

@augustl
Copy link

augustl commented Nov 29, 2023

We currently use our own fork of serverless-bundle because of this. Good work, hope this gets merged!

@jayair jayair added the enhancement New feature or request label Nov 29, 2023
@jayair
Copy link
Member

jayair commented Nov 30, 2023

Thank you for this (and adding the tests)!

@jayair jayair merged commit 3f3bbbc into AnomalyInnovations:master Nov 30, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants