Skip to content

Commit

Permalink
Using specific Bootstrap css version
Browse files Browse the repository at this point in the history
  • Loading branch information
@jayair
jayair committed Feb 5, 2018
1 parent 08bce12 commit d90baa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion public/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
Learn how to configure a non-root public URL by running `npm run build`.
-->
<link rel="stylesheet" type="text/css" href="https://fonts.googleapis.com/css?family=PT+Serif|Open+Sans:300,400,600,700,800">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">
<title>Scratch - A simple note taking app</title>
</head>
<body>
Expand Down

3 comments on commit d90baa7

@tommedema
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayair good catch; I noticed that https://demo.serverless-stack.com did not yet reflect this change until I did a few refreshes. Seems like the service worker does not auto update the app on load. The console said "new changes; please refresh" but of course ordinary users would not see this.

@jayair
Copy link
Member Author

@jayair jayair commented on d90baa7 Mar 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommedema Yeah the service worker causes a lot of these issues. It's enabled by default in create react app. I'm still debating if we should ask people to turn it off in the tutorial. Perhaps just mention the issues and let people decide.

@tommedema
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayair I figured if the service worker can console log that we need to refresh, it could also auto refresh the page assuming the state is still in its initial state. That would be ideal. But that is outside the scope of this guide, I guess. So yes, mentioning it would be nice. :)

Please sign in to comment.