-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kitty z-index feature #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Added `KittyImage._style_args`. - Add: Added `z_index` style-specific parameter for "kitty" render style.
- Add: Added `KittyImage.draw()` for the purpose of documentation.
- Add: Added `KittyImage._check_style_format_spec()`. - Add: Documented "kitty" style-specific format specification.
AnonymouX47
added
documentation
Improvements or additions to documentation
enhancement
New feature / Improvement suggestion or request
lib
Related to the library (Not to be used anymore)
cli
Related to the image viewer's CLI (Not to be used anymore)
tui
Related to the image viewer's TUI (Not to be used anymore)
labels
Jun 7, 2022
- Add: Added `_KITTY_VERSION` and `_KONSOLE_VERSION` to `KittyImage`. - Change: Now using `CSI > q` for terminal identification in `KittyImage`.
- Add: Added workaround for different supported terminal emulators and specific versions having various limitations.
- Add: Added `--kitty-z-index` CL option. - Change: Improved handling of style-specific CL options.
- Add: Added `.tui.render.style_specs`. - Add: Added `Image._ti_style_spec`.
- Add: Added kitty style format spec for the TUI. - Add: Added workarounds for image re-drawing and animation in the TUI. - Fix: Worked around repeated image blending on Kitty.
- Fix: Fixed output deadlock and messed up terminal state when image drawing is interrupted mid-transmission. - Add: Added `KittyImage._handle_interrupted_draw()`.
- Change: Removed `_render_image_lines` and `_render_image_whole` in `KittyImage`.
- Add: Added `mix` to `KittyImage._style_args`. - Change: Updated `KittyImage.draw()` docstring.
- Fix: Corrected default argument value check in `KittyImage.draw()`. - Add: Added format specification for `mix` style-specific parameter of the kitty render style. - Change: Updated kitty style-specific format specification documentation.
AnonymouX47
force-pushed
the
kitty-z-index
branch
from
June 8, 2022 01:17
e212ef4
to
15055cb
Compare
- Fix: Main parser now recognizes style-specific options.
- Change: Handled uninterpretable version numbers in `KittyImage.is_supported()`. - Change: Updated `KittyImsge` doc.
- Change: Disabled retrieval of pixel data as it's unneeded. - Aproximately 1.5x faster rendering. - Change: Replaced blank fill with XTerm erase + cursor movement escape sequences. - Change: Updated render tests.
- Add: Added tests for 'kitty' style-specific parameters `z_index` and `mix`. - Add: Added tests for 'kitty' style-specific format specification.
AnonymouX47
added a commit
that referenced
this pull request
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cli
Related to the image viewer's CLI (Not to be used anymore)
documentation
Improvements or additions to documentation
enhancement
New feature / Improvement suggestion or request
lib
Related to the library (Not to be used anymore)
tui
Related to the image viewer's TUI (Not to be used anymore)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #40
z_index
style-specific parameter for "kitty" render style.mix
style-specific parameter for "kitty" render style.--kz/--kitty-z-index
.