Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal size-relative padding #91

Merged
merged 5 commits into from
May 31, 2023
Merged

Terminal size-relative padding #91

merged 5 commits into from
May 31, 2023

Conversation

AnonymouX47
Copy link
Owner

  • Adds support for terminal size-relative padding.
    • Compensates for removal of allowances.
  • Redefines pad_width and pad_height formatting parameters.
    • No longer accept None.
    • Now accept non-positive integers.
    • Changed default values to 0 and -2 respectively.

@AnonymouX47
!feat: Implement terminal size-relative padding
cda3622 
- Add: Support for setting padding size relative to the terminal size.
  - Compensates for removal of allowances.
- Change: Redefined *pad_width* and *pad_height* formatting parameters.
  - No longer accept `None`.
  - Now accept non-positive integers.
  - Changed default values to `0` and `-2` respectively.
@AnonymouX47
test: Rewrite render formatting tests
444857c 
- Change: Remove unused parameters and variables.
- Change: Use the new default values for *pad_width* and *pad_height*.
- Change: Hard-code expected results instead of calculating.
@AnonymouX47
test: Add tests for terminal size-relative padding
52d94b7
@AnonymouX47
docs: Update render formatting documentation
b2ea69d 
- Change: Update docstrings of `draw()` and `_format_render()` in
  `BaseImage`.
@AnonymouX47 AnonymouX47 added common Related to the interface common to all render styles improvement Implementation of improvement to an existing feature labels May 31, 2023
@AnonymouX47 AnonymouX47 added this to the 0.7.0 milestone May 31, 2023
@AnonymouX47 AnonymouX47 merged commit bcd5d62 into main May 31, 2023
@AnonymouX47 AnonymouX47 deleted the terminal-relative-padding branch May 31, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common Related to the interface common to all render styles improvement Implementation of improvement to an existing feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AnonymouX47