Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-Export (Sourcery refactored) #21

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jun 19, 2021

Pull Request #20 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the JSON-Export branch, then run:

git fetch origin sourcery/JSON-Export
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from Anselmoo June 19, 2021 15:45
Comment on lines -33 to +37
if self.spin_state in [4, 5, 6]:
if self.spin_state in {4, 5, 6}:
self._size = 42
if self.spin_state in [3, 7]:
if self.spin_state in {3, 7}:
self._size = 19
if self.spin_state in [2, 8]:
if self.spin_state in {2, 8}:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function CMDmain.__init__ refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jun 19, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.21 ⭐ 5.21 ⭐ 0.00
Method Length 133.89 😞 133.89 😞 0.00
Working memory 11.74 😞 11.74 😞 0.00
Quality 55.15% 🙂 55.15% 🙂 0.00%
Other metrics Before After Change
Lines 320 320 0
Changed files Quality Before Quality After Quality Change
tanabe/main.py 55.15% 🙂 55.15% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tanabe/main.py CMDmain.calculation 10 🙂 269 ⛔ 17 ⛔ 34.69% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabe/main.py CMDmain.ci_cut 7 ⭐ 210 ⛔ 17 ⛔ 40.80% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabe/main.py CMDmain.__init__ 4 ⭐ 115 🙂 13 😞 57.83% 🙂 Extract out complex expressions
tanabe/main.py CMDmain.ts_print 4 ⭐ 167 😞 9 🙂 59.29% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Anselmoo Anselmoo merged commit a8247ec into JSON-Export Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant