Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ⚡ Add complete poetry #26

Merged
merged 5 commits into from
Jan 13, 2023
Merged

feat: ⚡ Add complete poetry #26

merged 5 commits into from
Jan 13, 2023

Conversation

Anselmoo
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 13, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.44%.

Quality metrics Before After Change
Complexity 1.29 ⭐ 0.74 ⭐ -0.55 👍
Method Length 146.69 😞 140.64 😞 -6.05 👍
Working memory 29.14 ⛔ 31.56 ⛔ 2.42 👎
Quality 50.09% 🙂 49.65% 😞 -0.44% 👎
Other metrics Before After Change
Lines 2122 1827 -295
Changed files Quality Before Quality After Quality Change
tanabesugano/__init__.py 100.00% ⭐ 100.00% ⭐ 0.00%
tanabesugano/batch.py 46.24% 😞 47.33% 😞 1.09% 👍
tanabesugano/matrices.py 49.43% 😞 49.43% 😞 0.00%
tanabesugano/test/test_front.py 97.01% ⭐ 97.90% ⭐ 0.89% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tanabesugano/batch.py Batch.calculation 17 🙂 335 ⛔ 13 😞 31.36% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabesugano/matrices.py d5.T_2_2_states 0 ⭐ 683 ⛔ 104 ⛔ 33.41% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabesugano/matrices.py d5.T_2_1_states 0 ⭐ 477 ⛔ 68 ⛔ 33.95% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabesugano/matrices.py d4.T_1_2_states 0 ⭐ 389 ⛔ 53 ⛔ 34.83% 😞 Try splitting into smaller methods. Extract out complex expressions
tanabesugano/matrices.py d6.T_3_1_states 0 ⭐ 387 ⛔ 53 ⛔ 34.86% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Anselmoo Anselmoo merged commit 918007e into master Jan 13, 2023
@Anselmoo Anselmoo deleted the develop branch January 13, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant