-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use the docker-engine #8
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
|
||
- name: Install Docker Repository | ||
template: src=docker-repo.j2 dest=/etc/yum.repos.d/docker.repo | ||
|
||
- name: Install Docker Engine | ||
yum: name=docker-engine state=present | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,17 @@ | |
when: docker_create_group | ||
tags: | ||
- config | ||
|
||
|
||
- name: Create the docker group and add your user | ||
command: usermod -aG docker {{ansible_ssh_user}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should use proper |
||
when: docker_create_group | ||
tags: | ||
- config | ||
|
||
- include: Debian.yml | ||
when: ansible_os_family == "Debian" | ||
|
||
- include: RedHat.yml | ||
when: ansible_os_family == "RedHat" | ||
|
||
- include: init.yml | ||
# - include: init.yml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# replace with gist variant | ||
docker_repo_key: "36A1D7869245C8950F966E92D8576A8BA88D21E9" | ||
docker_repo: "https://get.docker.io/ubuntu" | ||
docker_repo_key_server: "hkp://p80.pool.sks-keyservers.net:80" | ||
docker_repo_key: "58118E89F3A912897C070ADBF76221572C52609D" | ||
docker_repo: "https://apt.dockerproject.org/repo" | ||
docker_install_recommended_package: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem I see here is you only expect to be installed on Ubuntu system by using
ubuntu-{{ansible_distribution_release}}
. For vanilla Debian system, it'sdebian-{{ansible_distribution_release}}
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for the previous comment,
{{ ansible_distribution | lower }}-{{ ansible_distribution_release }}
is OK instead , isnt it? just FYI my patchset is ceaaf07