fixes #197

AnswerDotAI · Nov 13, 2020 · bc3b84f · bc3b84f
1 parent 7f909e2
commit bc3b84f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/fastcore/basics.py b/fastcore/basics.py
@@ -34,7 +34,7 @@ def basic_repr(flds=None):
     if isinstance(flds, str): flds = re.split(', *', flds)
     flds = list(flds or [])
     def _f(self):
-        sig = ', '.join(f'{o}={maybe_attr(getattr(self,o), "__name__")}' for o in flds)
+        sig = ', '.join(f'{o}={getattr(self,o)!r}' for o in flds)
         return f'{self.__class__.__name__}({sig})'
     return _f
 

diff --git a/nbs/01_basics.ipynb b/nbs/01_basics.ipynb
@@ -127,7 +127,7 @@
     "    if isinstance(flds, str): flds = re.split(', *', flds)\n",
     "    flds = list(flds or [])\n",
     "    def _f(self):\n",
-    "        sig = ', '.join(f'{o}={maybe_attr(getattr(self,o), \"__name__\")}' for o in flds)\n",
+    "        sig = ', '.join(f'{o}={getattr(self,o)!r}' for o in flds)\n",
     "        return f'{self.__class__.__name__}({sig})'\n",
     "    return _f"
    ]
@@ -159,8 +159,8 @@
     "sc = SomeClass()    \n",
     "ac = AnotherClass()\n",
     "\n",
-    "test_eq(repr(sc), 'SomeClass(a=1, b=foo)')\n",
-    "test_eq(repr(ac), 'AnotherClass(c=some-class, d=bar)')"
+    "test_eq(repr(sc), \"SomeClass(a=1, b='foo')\")\n",
+    "test_eq(repr(ac), \"AnotherClass(c=SomeClass(a=1, b='foo'), d='bar')\")"
    ]
   },
   {