fixes #543

AnswerDotAI · Oct 24, 2024 · 77152b5 · 77152b5
1 parent c19f540
commit 77152b5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/fasthtml/jupyter.py b/fasthtml/jupyter.py
@@ -17,19 +17,19 @@
 except ImportError: pass
 
 # %% ../nbs/api/06_jupyter.ipynb
-def nb_serve(app, log_level="error", port=8000, **kwargs):
+def nb_serve(app, log_level="error", port=8000, host='0.0.0.0', **kwargs):
     "Start a Jupyter compatible uvicorn server with ASGI `app` on `port` with `log_level`"
-    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, port=port, **kwargs))
+    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, host=host, port=port, **kwargs))
     async def async_run_server(server): await server.serve()
     @startthread
     def run_server(): asyncio.run(async_run_server(server))
     while not server.started: time.sleep(0.01)
     return server
 
 # %% ../nbs/api/06_jupyter.ipynb
-async def nb_serve_async(app, log_level="error", port=8000, **kwargs):
+async def nb_serve_async(app, log_level="error", port=8000, host='0.0.0.0', **kwargs):
     "Async version of `nb_serve`"
-    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, port=port, **kwargs))
+    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, host=host, port=port, **kwargs))
     asyncio.get_running_loop().create_task(server.serve())
     while not server.started: await asyncio.sleep(0.01)
     return server
@@ -76,15 +76,15 @@ def htmx_config_port(port=8000):
 # %% ../nbs/api/06_jupyter.ipynb
 class JupyUvi:
     "Start and stop a Jupyter compatible uvicorn server with ASGI `app` on `port` with `log_level`"
-    def __init__(self, app, log_level="error", port=8000, start=True, **kwargs):
+    def __init__(self, app, log_level="error", host='0.0.0.0', port=8000, start=True, **kwargs):
         self.kwargs = kwargs
         store_attr(but='start')
         self.server = None
         if start: self.start()
         htmx_config_port(port)
 
     def start(self):
-        self.server = nb_serve(self.app, log_level=self.log_level, port=self.port, **self.kwargs)
+        self.server = nb_serve(self.app, log_level=self.log_level, host=self.host, port=self.port, **self.kwargs)
 
     def stop(self):
         self.server.should_exit = True

diff --git a/nbs/api/06_jupyter.ipynb b/nbs/api/06_jupyter.ipynb
@@ -65,9 +65,9 @@
    "outputs": [],
    "source": [
     "#| export\n",
-    "def nb_serve(app, log_level=\"error\", port=8000, **kwargs):\n",
+    "def nb_serve(app, log_level=\"error\", port=8000, host='0.0.0.0', **kwargs):\n",
     "    \"Start a Jupyter compatible uvicorn server with ASGI `app` on `port` with `log_level`\"\n",
-    "    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, port=port, **kwargs))\n",
+    "    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, host=host, port=port, **kwargs))\n",
     "    async def async_run_server(server): await server.serve()\n",
     "    @startthread\n",
     "    def run_server(): asyncio.run(async_run_server(server))\n",
@@ -83,9 +83,9 @@
    "outputs": [],
    "source": [
     "#| export\n",
-    "async def nb_serve_async(app, log_level=\"error\", port=8000, **kwargs):\n",
+    "async def nb_serve_async(app, log_level=\"error\", port=8000, host='0.0.0.0', **kwargs):\n",
     "    \"Async version of `nb_serve`\"\n",
-    "    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, port=port, **kwargs))\n",
+    "    server = uvicorn.Server(uvicorn.Config(app, log_level=log_level, host=host, port=port, **kwargs))\n",
     "    asyncio.get_running_loop().create_task(server.serve())\n",
     "    while not server.started: await asyncio.sleep(0.01)\n",
     "    return server"
@@ -180,15 +180,15 @@
     "#| export\n",
     "class JupyUvi:\n",
     "    \"Start and stop a Jupyter compatible uvicorn server with ASGI `app` on `port` with `log_level`\"\n",
-    "    def __init__(self, app, log_level=\"error\", port=8000, start=True, **kwargs):\n",
+    "    def __init__(self, app, log_level=\"error\", host='0.0.0.0', port=8000, start=True, **kwargs):\n",
     "        self.kwargs = kwargs\n",
     "        store_attr(but='start')\n",
     "        self.server = None\n",
     "        if start: self.start()\n",
     "        htmx_config_port(port)\n",
     "\n",
     "    def start(self):\n",
-    "        self.server = nb_serve(self.app, log_level=self.log_level, port=self.port, **self.kwargs)\n",
+    "        self.server = nb_serve(self.app, log_level=self.log_level, host=self.host, port=self.port, **self.kwargs)\n",
     "\n",
     "    def stop(self):\n",
     "        self.server.should_exit = True\n",