Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toasts to work with FtResponse #526

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

tomasz-pankowski
Copy link


name: Pull Request
about: Fix for issues 486
title: '[PR] Allow toasts to work with FtResponse'
labels: 'bug', 'hacktoberfest'
assignees: ''


Related Issue
[BUG] FtResponse breaks toasts

Proposed Changes
Add FtResponse to list of supported response types

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Copy link

gitnotebooks bot commented Oct 16, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/526

@jph00 jph00 added the enhancement New feature or request label Oct 19, 2024
@jph00
Copy link
Contributor

jph00 commented Oct 19, 2024

Great!

@jph00 jph00 merged commit 190d272 into AnswerDotAI:main Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants