Skip to content

update _formitem so that it doesn't raise KeyError #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

comhar
Copy link
Contributor

@comhar comhar commented Mar 28, 2025

If the user doesn't include all request params in their request a KeyError will be raised when running _find_p.


name: Pull Request
about: Propose changes to the codebase
title: '[PR] '
labels: ''
assignees: ''


Related Issue
#693

Proposed Changes
This pr updates _formitem so that is does a safe dict lookup and no longer throws a KeyError.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
N/A

If the user doesn't include all request params in their request
a `KeyError` will be raised when running `_find_p`.

`_formitem` is updated to use a safe dict lookup.
@comhar comhar added the bug Something isn't working label Mar 28, 2025
@comhar comhar self-assigned this Mar 28, 2025
Copy link

gitnotebooks bot commented Mar 28, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/694

@comhar comhar requested a review from jph00 March 28, 2025 13:55
@jph00
Copy link
Contributor

jph00 commented Mar 29, 2025

Great PR @comhar -- thanks for the notes/tests in the nb :)

@jph00 jph00 merged commit b1c1ef0 into main Mar 29, 2025
2 checks passed
@jph00 jph00 deleted the fix-missing-param-bug branch March 29, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants