Test insert() and insert_all()

[pydanny]

• Resolves Table.insert() with Falsy value generates an error #42
• Works with both the main branch of sqlite-minutils as well as the addition of RETURNING * Add data returns for INSERT/UPDATE/UPSERT sqlite-minutils#42

[gitnotebooks]

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fastlite/pull/41

[audreyfeldroy]

Thanks for fixing our tests @pydanny! I found a couple tiny things to fix here, otherwise nice work.

[audreyfeldroy]

Commented on notebook nbs/test_insert.ipynb Cell 13 Line 1

Test None doesn't change anything. Note: The code below raises ZeroDivisionError: integer division or modulo by zero

@pydanny Remove my note if it's now returning {} :)

[audreyfeldroy]

Commented on notebook fastlite/_modidx.py Cell 1 Line 53

                               'fastlite.core._parse_typ': ('core.html#_parse_typ', 'fastlite/core.py'),
                               'fastlite.core._row': ('core.html#_row', 'fastlite/core.py'),
                               'fastlite.core._tnode': ('core.html#_tnode', 'fastlite/core.py'),
                               'fastlite.core.all_dcs': ('core.html#all_dcs', 'fastlite/core.py'),
                               'fastlite.core.create_mod': ('core.html#create_mod', 'fastlite/core.py'),
                               'fastlite.core.diagram': ('core.html#diagram', 'fastlite/core.py'),
                               'fastlite.core.get_typ': ('core.html#get_typ', 'fastlite/core.py')},
            'fastlite.db_dc': {},

Is there a way to exclude this, since it was just for a test?

[pydanny]

I'm not sure if we should leave it in or remove it.

[jph00]

Don't worry about _modidx (ever!)

[jph00]

If you moved this a couple of lines down I think you can just do “if record”?

[pydanny]

That doesn't work, it breaks the tests and behavior. Perhaps we're missing a detail?

[pydanny]

After looking at it again, we addressed this, reducing line count in the method.

[jph00]

Thank you!