Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Table.update() #43

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Test Table.update() #43

merged 3 commits into from
Nov 21, 2024

Conversation

pydanny
Copy link
Contributor

@pydanny pydanny commented Nov 20, 2024 •
edited
Loading

This PR does the following:

  • Adds tests for fastlite's Table.update() method
  • If an update's argument doesn't contain an input with fields/values, returns an empty dict. We may want to change this to raising an error
  • Works with both the current sqlite-minutils implementation and the Add data returns for INSERT/UPDATE/UPSERT sqlite-minutils#42

pydanny and others added 3 commits November 20, 2024 12:22
@pydanny
Create test_updates
a73afc0
@pydanny @audreyfeldroy
Working updates that do record checks
1ab9da6 
Co-authored-by: Audrey Roy Greenfeld <arg@answer.ai>
@pydanny @audreyfeldroy
Comprehensive update tests
657579b 
Co-authored-by: Audrey Roy Greenfeld <arg@answer.ai>
@gitnotebooks GitNotebooks
Copy link

gitnotebooks bot commented Nov 20, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fastlite/pull/43

@pydanny pydanny changed the title Test updates Test Table.update() Nov 20, 2024
@jph00 jph00 merged commit 9a8780f into main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pydanny @jph00