A fix for huge memory usage for larger files. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 20, 2016 14:17
|
The test which is currently failing, is that actually a bug (only whitespace is wrong)? |
| // Push the current body instance onto the stack for later execution. | ||
| while ( !reader.EndOfStream) | ||
| { | ||
| tw.Write(reader.ReadLine()); |
There was a problem hiding this comment.
ReadLine does not include the new line characters. That's why some tests are failing.
|
@AniaDomachowska Is this still being worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if there's no layout the result would be written directly to output stream?
I run into out of memory error while generating large files using RazorEngine.