Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Easy install of DUNE on Windows (publishing DUNE to Chocolatey repository) #96

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

mikelik
Copy link
Contributor

@mikelik mikelik commented Jan 4, 2023

I have pushed DUNE to Chocolatey repository: https://community.chocolatey.org/packages/antelopeio-dune/1.0.0

To install DUNE on Windows from scratch following steps are needed:

  1. Install Chocolatey
  2. In PowerShell run as administrator following command:
    choco install antelopeio-dune --version=1.0.0
  3. Restart your computer (this is because %PATH% has to be reloaded. In cmd.exe it will be enough to run command refreshenv, but it doesn't work in PowerShell).
  4. Open PowerShell / cmd.exe and try that following command works: dune.bat --version.

NOTE: After DUNE package is reviewed by Chocolatey's moderator it will be possible to skip "version" in above command.

@mikelik mikelik self-assigned this Jan 4, 2023
@mikelik mikelik linked an issue Jan 4, 2023 that may be closed by this pull request
1 task
@jolly-fellow
Copy link
Contributor

@mikelik Excellent. I just checked it on Windows 10 and 11. The installation works well.
I just want to ask, as a user, which is the easiest way to bypass installation of Python or Docker if I already have them installed? IMHO it would be good to describe this way in the documentation because, as I guess, it will be a frequent case.

@mikelik
Copy link
Contributor Author

mikelik commented Jan 5, 2023

@mikelik Excellent. I just checked it on Windows 10 and 11. The installation works well. I just want to ask, as a user, which is the easiest way to bypass installation of Python or Docker if I already have them installed? IMHO it would be good to describe this way in the documentation because, as I guess, it will be a frequent case.

Thanks @jolly-fellow!
Answer is here: https://stackoverflow.com/a/71605170
I will add the -n argument to the instruction.

I'm still waiting for the approval from Chocolatey team to publish the package.

@jolly-fellow
Copy link
Contributor

@mikelik Excellent. I just checked it on Windows 10 and 11. The installation works well. I just want to ask, as a user, which is the easiest way to bypass installation of Python or Docker if I already have them installed? IMHO it would be good to describe this way in the documentation because, as I guess, it will be a frequent case.

Thanks @jolly-fellow! Answer is here: https://stackoverflow.com/a/71605170 I will add the -n argument to the instruction.

IMHO it is not needed. Those who will have such problem easily find this option. I just wanted to make sure it is possible to skip some installations at all.

I'm still waiting for the approval from Chocolatey team to publish the package.

Don't worry. The installation already works well so IMHO it changes nothing. But generally I'd prefer don't support Windows at all. :)

@mikelik mikelik marked this pull request as ready for review January 5, 2023 12:04
@mikelik
Copy link
Contributor Author

mikelik commented Jan 5, 2023

The installation already works well so IMHO it changes nothing.

Ok, thanks, in that case let's merge this PR.
I will remove version once Chocolatey approves the package.

@kostia-ivashchenko
Copy link

2. choco install antelopeio-dune --version=1.0.0

Why does choco install ... downloads Docker Desktop? I have already have it installed,

@mikelik
Copy link
Contributor Author

mikelik commented Jan 5, 2023

  1. choco install antelopeio-dune --version=1.0.0
    Why does choco install ... downloads Docker Desktop? I have already have it installed,

Unfortunately free Chocolatey version does not discover already installed Docker Desktop via other means. However there is a workaround: https://stackoverflow.com/a/71605170

@mikelik mikelik linked an issue Jan 5, 2023 that may be closed by this pull request
Comment on lines +22 to +25
<dependencies>
<dependency id="python"/>
<dependency id="docker-desktop"/>
</dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Linux, @jolly-fellow and I found wget and curl were necessary for a working DUNE instance. I suspect these tools are still required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wget and curl were needed only by packaging scripts for Linux.
So for Windows we do not need them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this as well. LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wget and curl were needed only by packaging scripts for Linux. So for Windows we do not need them.

Actually curl used in a couple of functions in dune.py but these functions never used in the working code. May be it make sense to make an issue for removing of dead code from dune.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe curl is only used within the docker instance itself in main, so we could legitimately remove it from the deb and rpm dependencies.

Copy link
Contributor

@ScottBailey ScottBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either add wget and curl to dependencies or justify the absence.

@mikelik mikelik requested a review from ScottBailey January 5, 2023 18:59
Copy link
Contributor

@ScottBailey ScottBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +22 to +25
<dependencies>
<dependency id="python"/>
<dependency id="docker-desktop"/>
</dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this as well. LGTM.

@mikelik mikelik merged commit 962b774 into main Jan 9, 2023
@mikelik mikelik deleted the chocolatey-dependencies3 branch January 9, 2023 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants