-
Notifications
You must be signed in to change notification settings - Fork 17
Easy install of DUNE on Windows (publishing DUNE to Chocolatey repository) #96
Conversation
@mikelik Excellent. I just checked it on Windows 10 and 11. The installation works well. |
Thanks @jolly-fellow! I'm still waiting for the approval from Chocolatey team to publish the package. |
IMHO it is not needed. Those who will have such problem easily find this option. I just wanted to make sure it is possible to skip some installations at all.
Don't worry. The installation already works well so IMHO it changes nothing. But generally I'd prefer don't support Windows at all. :) |
Ok, thanks, in that case let's merge this PR. |
Why does |
Unfortunately free Chocolatey version does not discover already installed Docker Desktop via other means. However there is a workaround: https://stackoverflow.com/a/71605170 |
<dependencies> | ||
<dependency id="python"/> | ||
<dependency id="docker-desktop"/> | ||
</dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Linux, @jolly-fellow and I found wget
and curl
were necessary for a working DUNE instance. I suspect these tools are still required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wget and curl were needed only by packaging scripts for Linux.
So for Windows we do not need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed this as well. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wget and curl were needed only by packaging scripts for Linux. So for Windows we do not need them.
Actually curl used in a couple of functions in dune.py but these functions never used in the working code. May be it make sense to make an issue for removing of dead code from dune.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe curl is only used within the docker instance itself in main, so we could legitimately remove it from the deb and rpm dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please either add wget
and curl
to dependencies or justify the absence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<dependencies> | ||
<dependency id="python"/> | ||
<dependency id="docker-desktop"/> | ||
</dependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed this as well. LGTM.
I have pushed DUNE to Chocolatey repository: https://community.chocolatey.org/packages/antelopeio-dune/1.0.0
To install DUNE on Windows from scratch following steps are needed:
choco install antelopeio-dune --version=1.0.0
refreshenv
, but it doesn't work in PowerShell).dune.bat --version
.NOTE: After DUNE package is reviewed by Chocolatey's moderator it will be possible to skip "version" in above command.