Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Easy install of DUNE on Windows (publishing DUNE to Chocolatey repository) #96

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Easy install of DUNE on Windows (publishing DUNE to Chocolatey repository) #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
971d46c
Add dependencies for chocolatey package
Dec 30, 2022
64639aa
Remove packageSourceUrl to pass the Chocolatey validation
Jan 4, 2023
61335b5
Modify installation steps for Chocolatey.
Jan 5, 2023
cdec0c4
Modify `choco install` command until DUNE is fully approved in Chocol…
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,13 @@ After installation open `cmd.exe` and verify `python --version` returns current

#### DUNE installation on Windows <a name="dune-windows"></a>

1. Install [Chocolatey](https://docs.chocolatey.org/en-us/choco/setup)
2. From the [latest release](https://github.com/AntelopeIO/DUNE/releases/latest) page, download latest DUNE nupkg or visit the [release tags](https://github.com/AntelopeIO/DUNE/releases) page to download specific version of DUNE.
3. Run Windows Console as an Administrator, go to the directory where `nupkg` file has been downloaded and run:
`choco install antelopeio-dune.1.0.0.nupkg`
where `antelopeio-dune.1.0.0.nupkg` should be your just downloaded package.
4. DUNE is installed by default to `c:\programdata\chocolatey\lib\antelopeio-dune\tools` and it is added to PATH environment variable.
5. Run new cmd.exe windows and verify `dune.bat --version` returns current DUNE version.
1. Install [Chocolatey](https://docs.chocolatey.org/en-us/choco/setup).
2. In PowerShell run as administrator following command:
`choco install antelopeio-dune --version=1.0.0`
3. Restart your computer (this is because %PATH% has to be reloaded. In cmd.exe it is enough to run command `refreshenv`).
4. Open PowerShell / cmd.exe and try that following command works: `dune.bat --version`.

**NOTE**: Chocolatey does not detect python / docker-dekstop installed via other means, so it is possible some dependencies will be installed twice. Usually it is not an issue, but if it is you can follow [this solution](https://stackoverflow.com/a/71605170).

### Mac OS

Expand Down
7 changes: 5 additions & 2 deletions packaging/antelopeio-dune/antelopeio-dune.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<metadata>
<id>antelopeio-dune</id>
<version>1.0.0</version>
<packageSourceUrl>https://github.com/AntelopeIO/DUNE/packaging/antelopeio-dune.nuspec</packageSourceUrl>
<owners>EOS Network Foundation</owners>
<title>AntelopeIO DUNE</title>
<authors>EOS Network Foundation</authors>
Expand All @@ -16,10 +15,14 @@
<projectSourceUrl>https://github.com/AntelopeIO/DUNE</projectSourceUrl>
<bugTrackerUrl>https://github.com/AntelopeIO/DUNE/issues</bugTrackerUrl>
<summary>antelopeio-dune</summary>
<description>### antelopeio-dune package
<description>### antelopeio-dune eos cleos nodeos leap cdt antelope antelopeio
Docker Utilities for Node Execution (DUNE) is a tool to abstract over Leap programs, CDT and other services/tools related to Antelope blockchains.

</description>
<dependencies>
<dependency id="python"/>
<dependency id="docker-desktop"/>
</dependencies>
Comment on lines +22 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Linux, @jolly-fellow and I found wget and curl were necessary for a working DUNE instance. I suspect these tools are still required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wget and curl were needed only by packaging scripts for Linux.
So for Windows we do not need them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed this as well. LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wget and curl were needed only by packaging scripts for Linux. So for Windows we do not need them.

Actually curl used in a couple of functions in dune.py but these functions never used in the working code. May be it make sense to make an issue for removing of dead code from dune.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe curl is only used within the docker instance itself in main, so we could legitimately remove it from the deb and rpm dependencies.

</metadata>
<files>
<!-- this section controls what actually gets packaged into the Chocolatey package -->
Expand Down