Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Convert "version" option to flag "-V,--version". #34

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

ScottBailey
Copy link
Contributor

Convert "version" option to flag "-V,--version". This is consistent with both GNU and defacto standards.

Some formatting was changed (removed trailing white space).

I don't think it's necessary to add a test for this flag.

Fixes #29

@ScottBailey ScottBailey self-assigned this Apr 12, 2023
@mikelik
Copy link
Member

mikelik commented Apr 13, 2023

I would expect the -v to work, but only -V works.

mikel@msi:~/repo/antler-proj/build/tools$ ./antler-proj -v
The following argument was not expected: -v
Run with --help for more information.
mikel@msi:~/repo/antler-proj/build/tools$ ./antler-proj -V
antler-proj v1.0.0

Copy link
Member

@mikelik mikelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just learned that there are tools that support only case sensitive -V

@ScottBailey
Copy link
Contributor Author

I would expect the -v to work, but only -V works.

Lowercase v flag (-v) often - in my experience - represents verbose setting (--verbose). I sampled a couple tools on my Linux install and saw uppercase V was a synonym for version. Given we may want to add a verbose setting later, the other option was the long flag (--version) only, but I think -V is a nice option.

@ScottBailey ScottBailey merged commit 1b274aa into main Apr 13, 2023
@ScottBailey ScottBailey deleted the version_fix branch April 13, 2023 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

antler-proj --version not implemented
3 participants