Update tests to cover both const and non-const version of remove()

AntelopeIO · May 18, 2023 · a1aae5f · a1aae5f
1 parent 2b0fd5c
commit a1aae5f
Showing 1 changed file with 22 additions and 3 deletions.
diff --git a/tests/unit/test_contracts/multi_index_tests.cpp b/tests/unit/test_contracts/multi_index_tests.cpp
@@ -205,7 +205,7 @@ namespace _test_multi_index
  eosio::check(itr2 == table.end(), "idx64_general - table.erase()");
  }
 
- // insert, update and delete by iterator
+ // insert, update and remove by iterator
  {
  const uint64_t ssn = 421;
  auto new_person = table.insert(payer, [&](auto &r)
@@ -224,7 +224,7 @@ namespace _test_multi_index
  eosio::check(itr2 == table.end(), "idx64_general - table.remove()");
  }
 
- // insert, update and delete by object
+ // insert, update and remove by object
  {
  const uint64_t ssn = 421;
  auto new_person = table.insert(payer, [&](auto &r)
@@ -235,7 +235,26 @@ namespace _test_multi_index
  table.update(new_person, payer, [&](auto &r)
  { r.sec = "billy"_n.value; });
 
- table.remove(new_person);
+ const auto& person_object = table.get(ssn);
+ auto& mutable_person = const_cast<record&>(person_object);
+ table.remove(mutable_person);
+ auto itr2 = table.find(ssn);
+ eosio::check(itr2 == table.end(), "idx64_general - table.remove()");
+ }
+
+ // insert, update and remove by const object
+ {
+ const uint64_t ssn = 421;
+ auto new_person = table.insert(payer, [&](auto &r)
+ {
+ r.id = ssn;
+ r.sec = "bob"_n.value; });
+
+ table.update(new_person, payer, [&](auto &r)
+ { r.sec = "billy"_n.value; });
+
+ const auto& person_object = table.get(ssn);
+ table.remove(person_object);
  auto itr2 = table.find(ssn);
  eosio::check(itr2 == table.end(), "idx64_general - table.remove()");
  }