Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing support for get_code_hash host function #88

Closed
spoonincode opened this issue Dec 18, 2022 · 1 comment · Fixed by #109
Closed

missing support for get_code_hash host function #88

spoonincode opened this issue Dec 18, 2022 · 1 comment · Fixed by #109
Assignees
@dimas1185
Labels
actionable enhancement New feature or request 👍 lgtm

Comments

@spoonincode
Copy link
Member

cdt is missing support for the get_code_hash host function introduced with Antelope's GET_CODE_HASH protocol feature.
@heifner heifner added enhancement New feature or request actionable and removed triage labels Jan 10, 2023
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Ref AntelopeIO#88: Implement wrapper for get_code_hash
7d17621
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Resolve AntelopeIO#88: Testing for get_code_hash
2f9c71f
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Ref AntelopeIO#88: Implement wrapper for get_code_hash
23b70db
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Resolve AntelopeIO#88: Testing for get_code_hash
3ed23f0
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Ref AntelopeIO#88: Implement wrapper for get_code_hash
f78cbaa
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Feb 26, 2023
@nathanielhourt
Resolve AntelopeIO#88: Testing for get_code_hash
f7b206f
@nathanielhourt
Copy link
Contributor

Well, while I wait for someone to notice #97 and #99 (wink wink nudge nudge), I decided to look around for something else I could help out with and chose this issue.

Check out PReq #109 and let me know if I missed anything. =)

@spoonincode spoonincode linked a pull request Mar 8, 2023 that will close this issue
Resolve #88 #109
Merged
2 tasks
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Mar 14, 2023
@nathanielhourt
Ref AntelopeIO#88 Review updates: check retval of intrinsic
887b129 
Ensure the buffer was adequately large for the response and if not,
allocate sufficient space and call intrinsic again.
spoonincode added a commit that referenced this issue Mar 19, 2023
@spoonincode
Merge pull request #109 from dapp-protocols/issue-88
7909340 
Resolve #88
dimas1185 pushed a commit that referenced this issue Jun 8, 2023
@nathanielhourt @dimas1185
Ref #88: Implement wrapper for get_code_hash
0081b38
dimas1185 pushed a commit that referenced this issue Jun 8, 2023
@nathanielhourt @dimas1185
Resolve #88: Testing for get_code_hash
0093871
dimas1185 pushed a commit that referenced this issue Jun 8, 2023
@nathanielhourt @dimas1185
Ref #88 Review updates: check retval of intrinsic
c46ea84 
Ensure the buffer was adequately large for the response and if not,
allocate sufficient space and call intrinsic again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimas1185 dimas1185

Labels
actionable enhancement New feature or request 👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #88 dapp-protocols/leap-cdt
6 participants
@nathanielhourt @heifner @spoonincode @dimas1185 @stephenpdeos @enf-ci-bot