multi_index bugfix after migration from boost + tests #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelik
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
I would appreciate if someone more experienced in CDT would review this.
It LGTM, tests are passing. Contract which was failing before works fine.
I couldn't compile contracts described in #90 (because their code is not compiling with newest CDT) but if there will be any issues with it Zeus team will create a new issue.
ScottBailey
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #137
Also I copied
multi_indextests from leap as they have much more coverage than we have in cdt.Note for reviewer:
new tests were added to
integration_tests. Those tests requireleapand we do not execute them by default as part ofBuild & Teststeps. Please check those locally. All you need is to have a leap in your path sofind_package(leap)would find it. The reason we needleapis testing utilities and primarily classeosio::testing::testerto load contracts, produce blocks, etc.Change Description
API Changes
Documentation Additions