Make leap-dev download target configurable. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use defaults.json to specify default location/target to attempt to downlaod the leap-dev package from. Allow dynamic configuration through workflow_dispatch input in github.
oschwaldp-oci
changed the title
dimas1185
approved these changes
Sep 5, 2023
spoonincode
approved these changes
Sep 5, 2023
.github/workflows/build.yaml
Outdated
| with: | ||
| owner: AntelopeIO | ||
| repo: leap | ||
| file: 'leap-dev.*(x86_64|amd64).deb' | ||
| target: main | ||
| target: '${{needs.versions.outputs.leap-dev-target}}' | ||
| prereleases: ${{fromJSON(needs.versions.outputs.leap-dev-prerelease)}} | ||
| artifact-name: leap-dev-ubuntu20-amd64 | ||
| container-package: experimental-binaries | ||
| token: ${{github.token}} |
There was a problem hiding this comment.
with v3 you can get rid of this line
There was a problem hiding this comment.
Thanks for the reminder. I keep forgetting that is no longer required with v3. Removed.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Make leap-dev download target configurable.
Use
defaults.jsonto specify default location/target to attempt to download theleap-devpackage from. Allow dynamic configuration throughworkflow_dispatchinput in github.Resolves: #216
For example:
The run here: Manual Build & Test Run was manually dispatched from
cdtbranchcicd-override-leap-dev-targetwith theOverride leap-dev targetinput set tohotstuff_integration. This can be seen in theBuild & Test (ubuntu20)output in the stepDownload leap-dev.deb (Ubuntu20 only):