[4.0] fix -fnative linking on macOS
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
changed the title
-fnative linking on macOS-fnative linking on macOS
heifner
approved these changes
Sep 18, 2023
dimas1185
approved these changes
Sep 19, 2023
dimas1185
reviewed
Sep 19, 2023
| @@ -546,14 +547,31 @@ static void GetLdDefaults(std::vector<std::string>& ldopts) { | |||
| } else { | |||
| #ifdef __APPLE__ | |||
| ldopts.insert(ldopts.end(), {"-arch", "x86_64", "-macosx_version_min", "10.13", "-framework", "Foundation", "-framework", "System"}); | |||
|
|
|||
| llvm::SmallString<256> Output; | |||
There was a problem hiding this comment.
please keep naming according to the file. Rest of file has snake case
There was a problem hiding this comment.
good call; it's a tough mix because LLVM's naming standard is different than ours..
|
disappointed to discover this only resolves building on macOS up through Xcode 13.4. Xcode 14 & 15 will not build cdt due to other issues (unrelated to anything macOS related, but rather clang compiler related). oh well, at least it is an improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building cdt on macOS, it would error out about not being able to find the Foundation framework. This was because when cdt's ld driver was run with
-fnativeit didn't tellldthe system's SDK path.The current SDK can be discovered via
xcrun --show-sdk-path. I'm not sure any other way, so call off to that when creating the command line arguments to pass told. You can find something a little similar when cmake initializes its environment, so I'm not completely out of whack: https://github.com/Kitware/CMake/blob/123cdf981661c8ae32335d4ae7e1ddcbcffd09cc/Modules/Platform/Darwin-Initialize.cmake#L144I also removed
-Bstaticas that isn't accepted by macOS's linker any longer. afaict that is unneeded since-staticwill be passed anyways.