Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> main] migrate to find_package(Python) for cmake 3.27+ #228

Merged
merged 4 commits into from
Sep 19, 2023
Merged

[4.0 -> main] migrate to find_package(Python) for cmake 3.27+ #228

merged 4 commits into from
Sep 19, 2023

Conversation

spoonincode
Copy link
Member

This merges up the cmake python fix in #224

ericpassmore
ericpassmore approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from basic_string_fix_to_main to main September 19, 2023 22:57
@spoonincode spoonincode merged commit c3af527 into main Sep 19, 2023
6 checks passed
@spoonincode spoonincode deleted the llvm_python_find_package branch September 19, 2023 22:57
@ericpassmore
Copy link
Contributor

Note:start
group: RELEASE
category: CHORE
summary: Upgrade python find function.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@ericpassmore ericpassmore ericpassmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spoonincode @ericpassmore @heifner