Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove antler-proj #236

Closed
wants to merge 24 commits into from
Closed

Remove antler-proj #236

wants to merge 24 commits into from

Conversation

dimas1185
Copy link
Contributor

removing antler-proj
resolves #206

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@dimas1185
revert
a6fc5c8
@dimas1185
Revert "revert back cturtle changes"
8f45a07 
This reverts commit 772926c.
@dimas1185
revert
d8c090a
@dimas1185
reverting antler-proj
3e58753
@dimas1185
Revert "ubuntu 18 build fix"
603df6b 
This reverts commit 1a8b4d7.
@dimas1185
Revert "fixing ubuntu 22 build"
8e4a6c9 
This reverts commit b1fd200.
@dimas1185
reverting antler-proj
ca943e7
@dimas1185
Revert "remove libcurl4-openssl"
b073b3c 
This reverts commit 92116ad.
@dimas1185
Revert "update cicd"
67875b3 
This reverts commit 88d1569.
@dimas1185
Revert "updates to allow for building and proper generation of packages"
8d4de8a 
This reverts commit be71fb0.
@dimas1185
reverting antler-proj
9d5e219
@dimas1185
Revert "fix build & test step: adding boost"
3e7033c 
This reverts commit cb02ee5.
@dimas1185
Revert "fixing build & test step"
920370b 
This reverts commit 5f50526.
@dimas1185
Revert "fix build & test step"
cb8b141 
This reverts commit a78788f.
@dimas1185
Revert "install step fix"
58ba7ba 
This reverts commit 32614bf.
@dimas1185
Revert "fix build after adding antler-proj"
81b8ddb 
This reverts commit 87184a2.
@dimas1185
Revert "add antler-proj to cdt"
93092c1 
This reverts commit 9736614.
@dimas1185
resolve incorrect revert
f65ad1c
@dimas1185
correct revert
9230d74
@dimas1185
fix revert
83cf6ec
@dimas1185
fix revert errors
acd1d3d
@dimas1185 dimas1185 changed the title Rm antler proj Remove antler-proj Sep 30, 2023
ericpassmore
ericpassmore approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ericpassmore ericpassmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arhag
arhag requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@arhag arhag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is meant to be in CDT 4.0.1 as the linked issue milestone suggests, then this PR should be closed and a new one targeting release/4.0 should be opened. Make sure to add the [4.0] prefix to the title of the new PR as well.

scripts/generate_tarball.sh
@@ -64,8 +64,6 @@ create_symlink eosio-pp eosio-pp
create_symlink cdt-init cdt-init
create_symlink eosio-wasm2wast eosio-wasm2wast
create_symlink eosio-wast2wasm eosio-wast2wasm
create_symlink eosio-wasm2wast cdt-wasm2wast
create_symlink eosio-wast2wasm cdt-wast2wasm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these two symlinks removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, should not do this. probably an error in a reverted commit.

@ericpassmore ericpassmore changed the base branch from main to release/4.0 October 3, 2023 22:16
@ericpassmore ericpassmore changed the base branch from release/4.0 to main October 3, 2023 22:17
@dimas1185
Copy link
Contributor Author

will get to main later after merge from release/4.0. corresponding release/4.0 PR - #238

@dimas1185 dimas1185 closed this Oct 5, 2023
@dimas1185 dimas1185 deleted the rm-antler-proj branch October 19, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag requested changes

@ericpassmore ericpassmore ericpassmore approved these changes

@linh2931 linh2931 Awaiting requested review from linh2931

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlink Antler From Build
3 participants
@dimas1185 @ericpassmore @arhag