add shared object option to CDTMacros #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas1185
changed the title
larryk85
approved these changes
Jan 20, 2023
ScottBailey
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
LGTM
My only question is regarding the setting of CMake policy CMP0002 to OLD. Assuming it doesn't cause problems, switching this to new seems like a good plan since it is deprecated and may be removed in future.
If it is a problem, we should probably write a defect against it so it doesn't surprise us if/when CMake deprecates the policy.
larryk85
approved these changes
Jan 23, 2023
ScottBailey
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#78
Change was tested locally.
I'm planning to add tests together with
antler-runbinary.antler-runis supposed to load and executeapplyexported function.Change Description
API Changes
Documentation Additions