Test Coverage ram_actions Return Values #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created method to compute hex from provided JSON, this can be used as the expected return code Created method to extract trace->act and return data Commits fail as return data does not survive outside for-loop and is empty when compared to expected value
ericpassmore
changed the title
DenisCarriere
approved these changes
Feb 2, 2024
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage for ram action return values
Change Description
Added test method
convert_json_to_hex, takes a json and converts it to hex. This is used to generate expected return codes from methods.Added 6 methods that execute
ram_actionsand take additional arguments with the expected return codes, and ensure expected and actual return codes match.validate_buyram_returnvalidate_ramtransfer_returnvalidate_ramburn_returnvalidate_buyrambytes_returnvalidate_sellram_returnvalidate_buyramself_returnResolves #44