Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up instant finality names #353

Closed
arhag opened this issue Jul 10, 2024 · 0 comments · Fixed by #364
Closed

Clean up instant finality names #353

arhag opened this issue Jul 10, 2024 · 0 comments · Fixed by #364
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Cusp

Comments

@arhag
Copy link
Member

arhag commented Jul 10, 2024

Instead of instant_finality we can either use finality or savanna.
@arhag arhag added this to the Savanna: Cusp milestone Jul 10, 2024
@arhag arhag removed the triage label Jul 10, 2024
@heifner heifner self-assigned this Jul 11, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Jul 11, 2024
heifner added a commit that referenced this issue Jul 12, 2024
@heifner
GH-353 Renamed instant_finality_extension to finality_extension
0a0cb71
@heifner heifner mentioned this issue Jul 12, 2024
Merged
heifner added a commit that referenced this issue Jul 15, 2024
@heifner
GH-353 rename some variables
dae8e99
heifner added a commit that referenced this issue Jul 15, 2024
@heifner
Merge pull request #364 from AntelopeIO/GH-353-finality-name
17d9980 
Rename instant_finality_extension to finality_extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Cusp
Development

Successfully merging a pull request may close this issue.

Rename instant_finality_extension to finality_extension AntelopeIO/spring
3 participants
@heifner @arhag @enf-ci-bot