Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2 -> main] Remove explicit net_plugin pause during snapshot #784

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Sep 16, 2024

As noted on the addition of pausing during snapshot:
https://github.com/AntelopeIO/leap/pull/2029/files#r1440851488

Pausing does cause peers to disconnect. You have to wait on the connection timer to reconnect and continue syncing.

Now that we no longer sync ahead: #635
The issue AntelopeIO/leap#2021 is not an issue anymore as we do not keep syncing ahead. The sync is limited by the sync-fetch-span.

Tested with EOS Mainnet node syncing and with an EOS Mainnet node in-sync.

Merges release/1.0 into main including #768

Resolves #592

@heifner heifner added the OCI Work exclusive to OCI team label Sep 16, 2024
@heifner heifner merged commit b2017c0 into main Sep 16, 2024
36 checks passed
@heifner heifner deleted the GH-592-snapshot-sync-timeout-main branch September 16, 2024 14:04
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Sep 17, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Plugins/Cleos/Utils
summary: No longer pause syncing during snapshot, main thread is no longer tied up during snapshot.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not timeout P2P connections when creating a snapshot
4 participants