Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] - remove --windowed flag from builds (use --console instead) #87

Closed
AnthonyMichaelTDM opened this issue Jul 14, 2024 · 1 comment · Fixed by #88
Closed

[Proposal] - remove --windowed flag from builds (use --console instead) #87

AnthonyMichaelTDM opened this issue Jul 14, 2024 · 1 comment · Fixed by #88
Labels
Status: Pending Attention is needed, issue hasn't been addressed Type: Enhancement New feature or request

Comments

@AnthonyMichaelTDM
Copy link
Owner

It's not always clear to users that the executable is intended to be run from the terminal, we should remove the --windowed flag from the build workflow so this if users start the executable from, say, an app launcher or file explorer, a console will be spawned and the gui will be attached to it.

Note: this won't affect Linux users, as the --windowed flag has no affect on Linux

Note: while I'm at it, it may be worth looking at the --onefile flag as well

@AnthonyMichaelTDM AnthonyMichaelTDM added Status: Pending Attention is needed, issue hasn't been addressed Type: Enhancement New feature or request labels Jul 14, 2024
@AnthonyMichaelTDM
Copy link
Owner Author

This is motivated in part by #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Attention is needed, issue hasn't been addressed Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant