build: use console mode and build as standalone exe #88
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is done by using the --onefile flag and adding editor.ui and guids.json as data files Note: the editor.ui and guids.json files are still included in the released archive, separately, this is for debugability.
AnthonyMichaelTDM
deleted the
87-proposal-remove-windowed-flag-from-builds-use-console-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always clear to users that the executable is intended to be run from the terminal, this change removes the --windowed flag from the build workflow so this if users start the executable from, say, an app launcher or file explorer, a console will be spawned and the gui will be attached to it.
Additionally, we now build the executable as a single standalone binary, that unpacks it's required files into a temp directory (this was done with the --onefile flag)