[Bug] Weapon Maintenance Incomplete

[kagrith]

Report

Describe the bug

Looks to be that the weapon maintenance bug only activates several weapons.
Previously had no maintenance unlocks at all, after using the new button, this is what i have.

To Reproduce

Steps to reproduce the behavior:

1. Open save with no maintenance.
2. Use the new mass actions button.
3. Load the save
4. Check weapon maintenance.

Expected behavior

All weapon maintenance maxxed.

Context

Save File

Included, Should work?

Environment

• OS: Win10
• Python Version: N/A

Checklist

• I know how to use check boxes
• I am using the most recent version of the editor
• I have installed the editor correctly:
  • Check only one:
    • I have installed the editor from the releases page
    • I an running the editor from source
• If the issue is with editing save files, I attached a copy of my save file from before any edits were attempted
  • Note: If you do not attach a save file, it will be significantly harder (and in some cases impossible) to diagnose your issue
• I have read through relevant Discussions and Issues (including closed ones) and confirm that my issue wasn't resolved previously
• I have filled out the issue template correctly, and to the best of my ability. If I have not, I understand that my issue may be closed with or without a response

[AnthonyMichaelTDM]

Does the issue occur if you have already unlocked weapon maintenance?

[kagrith]

I'll see if I can test that today

…

On Sat, Jul 20, 2024, 05:24 Anthony Rubick ***@***.***> wrote: Does the issue occur if you *have* already unlocked weapon maintenance? — Reply to this email directly, view it on GitHub <#96 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIBQWALAXRWRF5TULJ23CDZNI3GLAVCNFSM6AAAAABLFQ6IUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGA3TOMRYG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[simon-wg]

The issue I believe is that it is only able to unlock maintenance for weapons which you have at least some xp for.

If you haven't used the weapon at all the function is unable to find it in the save file, and therefore unable to max the maintenance for it.

[simon-wg]

It could be a fun project to get all the weapon guids and manually add them if they're missing, sorta like overclocks are handled.

But I'm a bit busy with work so that might have to wait a bit.

[AnthonyMichaelTDM]

Maybe, but that has greater risk of corrupting save files

[wahlp]

you could probably fetch the weapon guids from a save file with all weapon maintenance started, but i've identified the weapons here if needed
weapon_guids_cleaned.csv