-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to max your weapon maintenance rank #71
Added the ability to max your weapon maintenance rank #71
Conversation
Alright, now mypy appears to be happy, I'm thinking that since there's a few pr:s open right now that we can wait with the formatting so we don't get too many unneccessary merge conflicts. |
ran into an error trying to run on python 3.9.6
and then after removing the above type hint
keeping this would narrow supported versions only to 3.10 other than that, works as expected. all weapons were maxxed out, apart from an unlocked weapon with 0 xp. |
this line may've been removed when I merged branches? anyway, re-added it
this is likely going to be the last merge before 1.9 gets released, so I'm going to use it to resolve some flake8 lints and whatnot aswell |
I've tried this out, and it works well on my machine.
The issue is that entries are not created until the weapon has been used at least once and gotten some xp. However it works otherwise.