Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate from PySide2 to PySide6 (Qt5 -> Qt6) #73

Merged

Conversation

AnthonyMichaelTDM
Copy link
Owner

fixes #72

@AnthonyMichaelTDM AnthonyMichaelTDM linked an issue Jul 11, 2024 that may be closed by this pull request
@AnthonyMichaelTDM AnthonyMichaelTDM marked this pull request as ready for review July 11, 2024 06:09
@AnthonyMichaelTDM AnthonyMichaelTDM changed the title [Proposal] - Migrate from PySide2 to PySide6 (Qt5 -> Qt6) feat: Migrate from PySide2 to PySide6 (Qt5 -> Qt6) Jul 11, 2024
@AnthonyMichaelTDM AnthonyMichaelTDM self-assigned this Jul 11, 2024
Copy link
Contributor

@simon-wg simon-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good, works on my machine on both linux and windows. I had some warnings when running on linux about OpenGL, but my suggested changes should fix that.

src/main/python/main.py Outdated Show resolved Hide resolved
src/main/python/main.py Show resolved Hide resolved
@AnthonyMichaelTDM AnthonyMichaelTDM merged commit b0f44a0 into master Jul 11, 2024
5 checks passed
@AnthonyMichaelTDM AnthonyMichaelTDM deleted the 72-proposal-migrate-from-pyside2-to-pyside6-qt5-qt6 branch July 11, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] - Migrate from PySide2 to PySide6 (Qt5 -> Qt6)
2 participants