-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate from PySide2 to PySide6 (Qt5 -> Qt6) #73
Merged
AnthonyMichaelTDM
merged 9 commits into
master
from
72-proposal-migrate-from-pyside2-to-pyside6-qt5-qt6
Jul 11, 2024
Merged
feat: Migrate from PySide2 to PySide6 (Qt5 -> Qt6) #73
AnthonyMichaelTDM
merged 9 commits into
master
from
72-proposal-migrate-from-pyside2-to-pyside6-qt5-qt6
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
succesfully runs on my linux machine with python 3.12 in a venv
pros include: - better type hinting (mypy actually passes now, yay) - consolidated ui initialization logic
AnthonyMichaelTDM
changed the title
[Proposal] - Migrate from PySide2 to PySide6 (Qt5 -> Qt6)
feat: Migrate from PySide2 to PySide6 (Qt5 -> Qt6)
Jul 11, 2024
simon-wg
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooks good, works on my machine on both linux and windows. I had some warnings when running on linux about OpenGL, but my suggested changes should fix that.
AnthonyMichaelTDM
deleted the
72-proposal-migrate-from-pyside2-to-pyside6-qt5-qt6
branch
July 11, 2024 18:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #72