Add tests #99
Merged
Add tests #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
might be a good opportunity to standardise our development tools. the CI calls for flake8 and mypy but i'm not sure if you guys are using anything else on top of that. |
|
requirements-dev.txt looks good, flake8, mypy, and pytest are the standard tools for this project (and all my other python work) |
|
let's also go through some of the closed issues (that provided saves) and write tests to ensure that their issues were fixed, for cases where doing that makes sense |
|
Looks good, I also use black for formatting, which I'd recommend as well. |
AnthonyMichaelTDM
approved these changes
Jul 29, 2024
AnthonyMichaelTDM
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #78