Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Github Actions for Windows build #223

Closed
2 tasks done
pktiuk opened this issue Sep 16, 2021 · 6 comments · Fixed by #260
Closed
2 tasks done

Setup Github Actions for Windows build #223

pktiuk opened this issue Sep 16, 2021 · 6 comments · Fixed by #260
Labels
CI - Github Actions Issues involving usage of Github Actions and creating scripts used by ci good first issue Good for newcomers help from outside needed Issues, which cannot be entirely solved by our team, help from outside is needed. help wanted Extra attention is needed Windows Windows-only issues

Comments

@pktiuk
Copy link
Member

pktiuk commented Sep 16, 2021 •
edited
Loading

TODO:

I am looking for help with this one
@pktiuk pktiuk added good first issue Good for newcomers help wanted Extra attention is needed CI - Github Actions Issues involving usage of Github Actions and creating scripts used by ci help from outside needed Issues, which cannot be entirely solved by our team, help from outside is needed. Windows Windows-only issues labels Sep 16, 2021
@pktiuk pktiuk mentioned this issue Sep 16, 2021
Closed
7 tasks
@pktiuk pktiuk mentioned this issue Sep 24, 2021
Closed
@avinal
Copy link
Member

avinal commented Oct 20, 2021 •
edited
Loading

Hello @pktiuk, I think I can help with both the tasks and I would like to work on this. I looked in the linked issues (#4) and it seems now the app compiles well on Windows. If that is the case then it won't take much time for the first task. (dependency issue may stretch the duration, typical Windows 😢 )

The second task however is dependent on the CPack (or any other configuration this project uses for packaging), I couldn't find a clear indication for that but I may be able to work that out too. Please let me know if I missed anything.

@pktiuk
Copy link
Member Author

pktiuk commented Oct 20, 2021 •
edited
Loading

Hello @avinal

It would be great :)
I tried to deal with this task, but without any success.

The second task however is dependent on the CPack (or any other configuration this project uses for packaging), I couldn't find a clear indication for that but I may be able to work that out too. Please let me know if I missed anything.

According to the second part of this task, it is linked with issue: #237 (updated issue description because it was not clear)
For now we don't have finished config for building Windows package (I stuck with that one too, mainly because of problems with installing dependencies).

@avinal
Copy link
Member

avinal commented Oct 21, 2021

I looked into your implementation and I think it is pretty much complete except for some dependencies and flags. I modified it a bit and it is working (partially) . It is generating an error c++.exe: error: unrecognized command-line option '-rdynamic' that seems to be related to this

https://github.com/AntiMicroX/antimicrox/blob/master/CMakeLists.txt#L47 line.

I also researched a bit and found people suggesting not to use -rdynamic. What should we do? I can try replacing with the suggested flags.

@pktiuk
Copy link
Member Author

pktiuk commented Oct 21, 2021

-rdynamic is used with debug builds only (required for proper printing stack trace in case of crash).

    set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wall -g -O0 -rdynamic -fno-omit-frame-pointer")

@pktiuk pktiuk mentioned this issue Oct 21, 2021
Merged
@pktiuk
Copy link
Member Author

pktiuk commented Oct 21, 2021

Now everything should work fine.

@avinal avinal mentioned this issue Oct 21, 2021
Merged
@avinal
Copy link
Member

avinal commented Oct 21, 2021

Done PR #260 ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI - Github Actions Issues involving usage of Github Actions and creating scripts used by ci good first issue Good for newcomers help from outside needed Issues, which cannot be entirely solved by our team, help from outside is needed. help wanted Extra attention is needed Windows Windows-only issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Add windows build GitHub Actions CI avinal/antimicrox
2 participants
@pktiuk @avinal