Restore Windows support #4

pktiuk · 2020-08-26T17:57:28Z

This project requires installer for Windows.

Original antimicro was compiled on Windows, but this fork doesn't have this feature yet.
Most of required components are already included in antimicro's repository (I think it would be a good point to start).

It would be nice to also add portable version of AntiMicroX, it was done there

Things to do:

compile AntimicroX on Windows Restore Windows build #220
Restore most of functionalities for Windows Restore full functionality of Windows build #225
- for now, support for vmulti input method will be disabled
Build Windows installer Prepare installer for Windows #237
Add CI for Windows to avoid breaking compatibility. Setup Github Actions for Windows build #223
- (optional) Add building and uploading exe to github actions on release
Ensure that config migration works properly in Windows Saves migration win #266
Add instruction for building to docs docs: Add Windows build instructions #265

This issue is migrated of original issue juliagoda/antimicroX#131 from legacy AntiMicroX repo.

⚠️ We are looking for developers familiarized with Windows for this one, because our team consists mostly of Linux users/developers.

The text was updated successfully, but these errors were encountered:

gombosg · 2020-09-12T16:36:01Z

While looking around for #32 I discovered this.

We need to learn what the original antimicro used as output library that was dropped in favor of Linux, and need to restore that event handler. See here.

pktiuk · 2020-09-16T21:46:41Z

Maybe we should stick to QT-based input methods, just like Qt Virtual Keyboard.
Maybe there is also a class for controlling mouse movement. 🤔

gombosg · 2020-09-17T17:55:02Z

Are you sure that you can generate OS input events with that? It just looks like... well, a virtual keyboard that the user can interact with.

pktiuk · 2020-09-17T19:44:52Z

It is virtual keyboard, but we could "borrow" some libraries used by this app :)

OlegPopow · 2020-10-18T16:46:44Z

In accordance with the wishes of the respected developer, I would like to ask about the progress of work on the Windows version. Yes, I've been using Windows to play games for some time, because unfortunately Wine does not fully meet my expectations. Some games work tragically on Wine so I had to apologize with Windows and install it after 17 years. I would be delighted if I could use the same program on two platforms and use the same profiles. Don't treat this as a rush, I just want to know if it makes any sense for me to wait or better to look for an alternative.

pktiuk · 2020-10-18T17:06:28Z

Currently, there is no measurable progress in restoring Windows support, now we are investigating possibilities of using more universal (independent on operating system) qt libraries, but while dealing with other issues we are still thinking about avoiding further breaking app for Windows (like avoiding deletion of default icons used by app, because QIcon::fromTheme won't work properly with Windows without defined fallback option).

This is still our top priority, but I am not able to deal with this task without preparations and getting familiar with the architecture of AntiMicroX, which is not as small and simple app as end-users may see it.
I am going to familiarize with structure of this project by fixing its bugs, cleaning its code/configs/files and (probably) improving logging to easier investigate problems with apps (I think it would be great to use multiple logs level in app, it would make debugging easier, because enabling all of logs gives huge output which is difficult to read)

AriaMoradi · 2020-11-08T21:47:34Z

take a look at https://github.com/Tylemagne/Gopher360 the code might help?

gombosg · 2020-11-15T19:44:49Z

Starting to try and install antimicrox on Windows... argh... :)

gombosg · 2020-11-18T10:51:57Z

I set up QT Creator on my Windows, and first tried to build the original antimicro using the build instructions there. It found the SDL DLL, compiled, but failed miserably during linking.
I have 32 bit cmake, QT (5.14.2), SDL, everything (except windows).
Attached logs to see if we find anything.
cmake.txt
build.txt

gombosg · 2020-11-18T14:54:43Z

In other words, where can I learn more, see logs about what is happening (and going wrong) during linking?

pktiuk · 2020-11-18T15:30:21Z

At first glance it seems that CMake was not searching for SDL2.
It would be good to have in legacy cmake lines (try to add it somewhere at the beginning):

find_package(SDL2 REQUIRED)
include_directories(${SDL2_INCLUDE_DIRS})

As an example cmake with sdl check this_link

I see find_library(SDL2_LIBRARY SDL2 ${SDL2_LIBRARY_DIR}), but it is less reliable solution than finding packages.

gombosg · 2020-11-22T23:10:10Z

After a lot of work, I managed to get the FindSDL2.cmake script running and using find_package for SDL2... to get to the same error. xD
Now that I looked through the 2 cmakelist files, I see about a dozen Windows-specific files in antimicro that have been removed from antimicrox.

gombosg · 2020-11-22T23:46:24Z

Ha! I was only 1 step from doing it, doing this AntiMicro/antimicro#207 helped.
Now we can move on to getting things working for antimicrox...

pktiuk · 2020-11-23T21:44:56Z

Is your current work on any branch?
In case if someone else would like to try it.

How you have installed SDL2?

gombosg · 2020-11-24T08:01:31Z

So far I pushed here: https://github.com/AntiMicro/antimicro/tree/windows-build-fix
I used the link you mentioned to install SDL2. Though I haven't done any Linux testing, all this was for Windows.

AriaMoradi · 2020-12-03T23:45:39Z

Ok, first I was doing some research around #114 and exploring the past issues/commits, and now I am starting to understand why juliagoda became so bitter about things in the end.
Windows support was neglected and I completely understand why, when you don't have access to a windows box and no help is around this is what happens.

To further eliviate the case first we need windows focused devs and testers. And second we should consider this a "port/back port" not a "restoration effort".
This might be to some degree in contradiction with #114.

gombosg · 2020-12-04T09:02:33Z

Yes. I need a day or so to just sit down and measure how big of an effort this would be. Fortunately, this day is like that. :)

AriaMoradi · 2020-12-04T13:53:28Z

original comment: #115 (comment)
copying it here so we can discuss it further here and not go off-topic in #115

Ok this is bad! to restore windows we probably have to bring back this deleted code(and probably much more...)

And also there's this:16b4af6
which is a part of 2.25(just a few versions after 2.23 which is made by the original team.)

Then I think to restore windows It maybe best to start from somewhere between 2.25 and 2.23 and port back new features from what we have now to windows...

pretty much from what I see AntimicroX(with *nix endig is which is cooler) could be Linux only and we could continue Antimicro as a windows (only?) project.

gombosg · 2021-02-26T13:57:18Z

I can get back to this in late March, or April, sorry. It's in progress and there is some hope. :)

Bigoukun · 2021-03-16T13:15:55Z

Good luck in restoring Windows compatibility. I can't help with the code, but I might be able to test any Windows version you'll be able to make.

marci-nlm · 2021-05-30T01:27:43Z

Hey, just found this open issue. I'll look into getting involved soon. Let me know if you need any testing done on windows

pktiuk · 2021-06-22T18:37:53Z

Sorry guys, but we haven't made any significant progress since then.
Everything done in this matter is (and will be) reported here. If you don't see any updates here you can safely assume there is no progress.

The USE_QT5 code path already unconditionally sets CMAKE_AUTOMOC to on. Calling QT5_WRAP_CPP() used to be just redundant, as antimicro_HEADERS_MOC was never actually added as a source dependency of the antimicro target. In other words, CMake's own automoc infrastructure was actually being used and the moc invocations from QT5_WRAP_CPP() were not being made at all. Starting with Qt 5.9.4, calling QT5_WRAP_CPP() disables the AUTOMOC property on the macro's input files, which means neither CMake's automoc infrastructure not QT5_WRAP_CPP()'s code were being used and we ended up with several 'undefined reference to vtable' errors when linking.

pktiuk · 2021-09-16T14:33:10Z

First step is made, app compiles on Windows and can be launched, but this task is still far from being done.

Anyway, does anybody have experience with configuring Github Actions for Windows? #223

pktiuk · 2021-10-22T10:32:58Z

STATUS UPDATE
Thanks to help from @avinal I will be able to prepare the first Windows AntiMicroX release within 2 weeks.

pktiuk · 2021-10-29T15:15:36Z

STATUS UPDATE
AntiMicroX 3.2.0 is now released 🎉
Installer can be downloaded from release site https://github.com/AntiMicroX/antimicrox/releases/tag/3.2.0
This is the first release supporting Windows.
Because of this there may be some brand-new Windows-only bugs in there.
That's why this release may be not as stable as legacy AntiMicro. In case of any bugs open bug issue. For other questions (about usage etc) feel free to open new thread in discussions.

Gkjsdll · 2021-10-29T15:24:25Z

Launching on Windows 10 after running the installer throws 4 separate errors about Qt5 dll's being missing. The order seems to change.

The code execution cannot proceed because Qt5Core.dll was not found. Reinstalling the program may fix this problem.
The code execution cannot proceed because Qt5Gui.dll was not found. Reinstalling the program may fix this problem.
The code execution cannot proceed because Qt5Concurrent.dll was not found. Reinstalling the program may fix this problem.
The code execution cannot proceed because Qt5Network.dll was not found. Reinstalling the program may fix this problem.

I've tried reinstalling as administrator and uninstall + reinstall, and a full system restart. I've also performed a full system restart.

pktiuk · 2021-10-29T15:28:44Z

Created new issue for this #268
Reinstalling won't help in this case.

pktiuk · 2021-10-30T14:49:43Z

Everything should now work fine.
Newly uploaded installer contains all of needed dll files

Grandma-Betty · 2021-11-06T06:33:26Z

Just downloaded antimicrox-3.2.0-AMD64.exe but when starting it on Windows 10 nothing happens. I also tried to run it as administrator but still: Nothing happens.
I'm on Windows 10 Version 21H1 (Build 19043.1320)
Any hints?
Thank you!

EDIT: Got it working running it in Windows 7 compatibility mode.

scarletfrank · 2021-11-24T15:04:26Z

Just downloaded antimicrox-3.2.0-AMD64.exe but when starting it on Windows 10 nothing happens. I also tried to run it as administrator but still: Nothing happens. I'm on Windows 10 Version 21H1 (Build 19043.1320) Any hints? Thank you!

EDIT: Got it working running it in Windows 7 compatibility mode.

I'm on Windows 10 Version 21H1 (Build 19043.1348). antimicrox-3.2.0-AMD64.exe works without administrator setting.
Also it might be a coincidence that I got Controller Companion working running it in Windows7 compatibility mode.
lol

pktiuk added enhancement New feature or request help wanted Extra attention is needed packaging Every issue linked with providing and fixing packages for different distributions and systems labels Aug 26, 2020

This was referenced Aug 26, 2020

Restore Windows installer juliagoda/antimicroX#131

Closed

Windows Build Instructions juliagoda/antimicroX#61

Open

General discussion about AntiMicroX and further development. #5

Closed

pktiuk added the help from outside needed Issues, which cannot be entirely solved by our team, help from outside is needed. label Aug 28, 2020

pktiuk pinned this issue Sep 6, 2020

pktiuk mentioned this issue Sep 12, 2020

Promoting AntiMicroX #34

Closed

This was referenced Sep 13, 2020

General discussion about AntiMicroX and further development #35

Closed

Please release a Win Installer/.exe #42

Closed

pktiuk mentioned this issue Nov 15, 2020

Discussion about further naming and future of this project. AntiMicro/antimicro#351

Closed

gombosg mentioned this issue Nov 15, 2020

Upstream migration. #85

Closed

gombosg mentioned this issue Nov 23, 2020

cmake: Stop calling QT5_WRAP_CPP(). AntiMicro/antimicro#207

Merged

gombosg mentioned this issue Dec 5, 2020

feat: Restore Windows build #119

Closed

pktiuk mentioned this issue Dec 18, 2020

[Feature Request] Popup on changing the set #122

Open

pktiuk mentioned this issue Feb 19, 2021

Windows installer coming? #150

Closed

This comment has been minimized.

Sign in to view

pktiuk mentioned this issue Sep 15, 2021

Restore Windows build #220

Merged

pktiuk changed the title ~~Restore Windows installer~~ Restore Windows support Sep 16, 2021

pktiuk added the Windows Windows-only issues label Sep 16, 2021

pktiuk mentioned this issue Sep 17, 2021

Restore full functionality of Windows build #225

Merged

avinal mentioned this issue Oct 20, 2021

Setup Github Actions for Windows build #223

Closed

2 tasks

pktiuk mentioned this issue Oct 28, 2021

chore(release): 3.2.0 #267

Merged

pktiuk closed this as completed in #267 Oct 29, 2021

pktiuk unpinned this issue Oct 29, 2021

zpangwin mentioned this issue Jan 26, 2022

Random Crashes during longer sessions #133

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Restore Windows support #4

Restore Windows support #4

pktiuk commented Aug 26, 2020 •

edited

Loading

gombosg commented Sep 12, 2020

pktiuk commented Sep 16, 2020

gombosg commented Sep 17, 2020

pktiuk commented Sep 17, 2020

OlegPopow commented Oct 18, 2020

pktiuk commented Oct 18, 2020

AriaMoradi commented Nov 8, 2020

gombosg commented Nov 15, 2020

gombosg commented Nov 18, 2020 •

edited

Loading

gombosg commented Nov 18, 2020

pktiuk commented Nov 18, 2020

gombosg commented Nov 22, 2020

gombosg commented Nov 22, 2020 •

edited

Loading

pktiuk commented Nov 23, 2020 •

edited

Loading

gombosg commented Nov 24, 2020

AriaMoradi commented Dec 3, 2020 •

edited

Loading

gombosg commented Dec 4, 2020

AriaMoradi commented Dec 4, 2020 •

edited

Loading

gombosg commented Feb 26, 2021

Bigoukun commented Mar 16, 2021

This comment has been minimized.

marci-nlm commented May 30, 2021

This comment has been minimized.

pktiuk commented Jun 22, 2021

This comment has been minimized.

pktiuk commented Sep 16, 2021 •

edited

Loading

pktiuk commented Oct 22, 2021 •

edited

Loading

pktiuk commented Oct 29, 2021 •

edited

Loading

Gkjsdll commented Oct 29, 2021

pktiuk commented Oct 29, 2021 •

edited

Loading

pktiuk commented Oct 30, 2021 •

edited

Loading

Grandma-Betty commented Nov 6, 2021 •

edited

Loading

scarletfrank commented Nov 24, 2021

Restore Windows support #4

Restore Windows support #4

Comments

pktiuk commented Aug 26, 2020 • edited Loading

gombosg commented Sep 12, 2020

pktiuk commented Sep 16, 2020

gombosg commented Sep 17, 2020

pktiuk commented Sep 17, 2020

OlegPopow commented Oct 18, 2020

pktiuk commented Oct 18, 2020

AriaMoradi commented Nov 8, 2020

gombosg commented Nov 15, 2020

gombosg commented Nov 18, 2020 • edited Loading

gombosg commented Nov 18, 2020

pktiuk commented Nov 18, 2020

gombosg commented Nov 22, 2020

gombosg commented Nov 22, 2020 • edited Loading

pktiuk commented Nov 23, 2020 • edited Loading

gombosg commented Nov 24, 2020

AriaMoradi commented Dec 3, 2020 • edited Loading

gombosg commented Dec 4, 2020

AriaMoradi commented Dec 4, 2020 • edited Loading

gombosg commented Feb 26, 2021

Bigoukun commented Mar 16, 2021

This comment has been minimized.

marci-nlm commented May 30, 2021

This comment has been minimized.

pktiuk commented Jun 22, 2021

This comment has been minimized.

pktiuk commented Sep 16, 2021 • edited Loading

pktiuk commented Oct 22, 2021 • edited Loading

pktiuk commented Oct 29, 2021 • edited Loading

Gkjsdll commented Oct 29, 2021

pktiuk commented Oct 29, 2021 • edited Loading

pktiuk commented Oct 30, 2021 • edited Loading

Grandma-Betty commented Nov 6, 2021 • edited Loading

scarletfrank commented Nov 24, 2021

pktiuk commented Aug 26, 2020 •

edited

Loading

gombosg commented Nov 18, 2020 •

edited

Loading

gombosg commented Nov 22, 2020 •

edited

Loading

pktiuk commented Nov 23, 2020 •

edited

Loading

AriaMoradi commented Dec 3, 2020 •

edited

Loading

AriaMoradi commented Dec 4, 2020 •

edited

Loading

pktiuk commented Sep 16, 2021 •

edited

Loading

pktiuk commented Oct 22, 2021 •

edited

Loading

pktiuk commented Oct 29, 2021 •

edited

Loading

pktiuk commented Oct 29, 2021 •

edited

Loading

pktiuk commented Oct 30, 2021 •

edited

Loading

Grandma-Betty commented Nov 6, 2021 •

edited

Loading