Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Commit

Permalink
cmake: Stop calling QT5_WRAP_CPP(). (#207)
Browse files Browse the repository at this point in the history 
The USE_QT5 code path already unconditionally sets CMAKE_AUTOMOC to on.

Calling QT5_WRAP_CPP() used to be just redundant, as antimicro_HEADERS_MOC
was never actually added as a source dependency of the antimicro target. In
other words, CMake's own automoc infrastructure was actually being used and
the moc invocations from QT5_WRAP_CPP() were not being made at all.

Starting with Qt 5.9.4, calling QT5_WRAP_CPP() disables the AUTOMOC property
on the macro's input files, which means neither CMake's automoc
infrastructure not QT5_WRAP_CPP()'s code were being used and we ended up
with several 'undefined reference to vtable' errors when linking.
  • Loading branch information
@rakuco
rakuco authored Dec 4, 2020
1 parent 2e69afb commit 985f0b1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,6 @@ if (UNIX)
find_package(Qt5Network REQUIRED)
find_package(Qt5LinguistTools REQUIRED)

QT5_WRAP_CPP(antimicro_HEADERS_MOC ${antimicro_HEADERS})
QT5_WRAP_UI(antimicro_FORMS_HEADERS ${antimicro_FORMS})
QT5_ADD_RESOURCES(antimicro_RESOURCES_RCC ${antimicro_RESOURCES})
add_subdirectory("share/antimicro/translations")
Expand Down Expand Up @@ -550,7 +549,6 @@ elseif(WIN32)
find_package(Qt5Network REQUIRED)
find_package(Qt5LinguistTools REQUIRED)

QT5_WRAP_CPP(antimicro_HEADERS_MOC ${antimicro_HEADERS})
QT5_WRAP_UI(antimicro_FORMS_HEADERS ${antimicro_FORMS})
QT5_ADD_RESOURCES(antimicro_RESOURCES_RCC ${antimicro_RESOURCES})
add_subdirectory("share/antimicro/translations")
Expand Down

4 comments on commit 985f0b1

@ae95
Copy link

@ae95 ae95 commented on 985f0b1 Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello , im interesting in antimicro program ,so Is there any software update coming? for example to use it by ps5 controller or windows 11

@pktiuk
Copy link
Contributor

@pktiuk pktiuk commented on 985f0b1 Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ae95,
antimicro is currently a legacy application (no updates are planned).
There is a new, actively developed fork called AntiMicroX, but that one doesn't support Windows (yet).
We plan to restore Windows support, but there is a long way ahead of us we are also looking for Windows developers which could help us with this task. AntiMicroX/antimicrox#4

@ae95
Copy link

@ae95 ae95 commented on 985f0b1 Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much but is currently program work with ps5 controller or windows 11 ?

@pktiuk
Copy link
Contributor

@pktiuk pktiuk commented on 985f0b1 Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.
On Linux ps5 controller is supported out of the box, IDK how it looks on Windows.

Please sign in to comment.