-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restore Windows build #119
Conversation
I also merged #112 into here, it'll end up on master soon anyway and that library also didn't work on Windows. |
It's better to not touch .gitignore @gombosg |
Could you elaborate? It's there to exclude build-generated stuff from git. I mostly know what I'm doing. :) |
I am not sure about this way of working with restoring windows support. |
I don't see where the problem is, this is standard git workflow. These commits will be squashed anyway on merge. Merging master into a feature branch every now and then is standard procedure to keep them updated. (At least we do it a t (And personally I find it much better than rebasing because rebasing modifies branch history and makes it nearly impossible to collaborate on a branch.) I'm not sure if merging half/non-working code to master is a good idea. If the project turns out to be not working after all or is abandoned, then we are either left with dead code in master or we have to revert. So we don't win much by that. |
I am not sure whether squashing so many changes into one commit is a good idea, It will make a history of development not very clear.
Yes, it makes nearly impossible collaborating when many people are working on a single branch, but currently there are only 3 of us and we could notify each other when we want to rebase to get some needed change from master. (we don't have to do it very often). |
If this ever gets merged, I promise to make an interactive rebase, squashing unnecessary commits. 😄 |
can you make a version that work on windows subsystem for linux |
Do you remember why quit shortcut functionality is removed here? |
You started this restoration well, but it may be difficult to merge it (due to big changes I've made during last year). |
I won't delete this branch yet, because there may be still something useful |
Closes #4
This is a long project. It already configures, generates UI files and gets to about 30% build. From here on, it's a matter of fixing build errors one by one and re-adding packaging stuff like Windows icons and installers.
It's easy because I can just take a look at
antimicro
code and copy over whatever's needed, but it's also long and risky (however much I work on this, it may not be successful...).