Refactor logging #176
Merged
Refactor logging #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be called only once
pktiuk
commented
Jul 10, 2021
| @@ -276,8 +248,6 @@ void Logger::appendLog(LogLevel level, const QString &message, bool newline) | |||
| */ | |||
| void Logger::directLog(LogLevel level, const QString &message, bool newline) | |||
There was a problem hiding this comment.
Hi @jsbackus,
Could you help me with this one?
Do you remember what was the reason of differentiating between directLog and appendLog?
Were there any performance issues with logs causing these optimizations?
|
Hi @pktiuk, hmm.. no, that must have been before my time. I didn't have
much of a chance to do any tuning.
…On Sat, Jul 10, 2021 at 4:20 PM Paweł Kotiuk ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/logger.cpp
<#176 (comment)>:
> @@ -276,8 +248,6 @@ void Logger::appendLog(LogLevel level, const QString &message, bool newline)
*/
void Logger::directLog(LogLevel level, const QString &message, bool newline)
Hi @jsbackus <https://github.com/jsbackus>,
Could you tell me with this one?
Do you remember what was the reason of differentiating between directLog
and appendLog?
Were there any performance issues with logs causing these optimizations?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#176 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPMVM52JE54YTDVDJNYTW3TXCTQJANCNFSM473BDCOQ>
.
--
Jeff Backus
***@***.***
http://github.com/jsbackus
|
|
This task is too big to do it at once. It will be more manageable if it would be split to pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some logging issues:
qDebugandLogger::LogDebug)qInstallMessageHandlerin every method is a bad idea, it should be called only ONCEPart of #177