Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add message informaing about solutions in case of problems wit… #248

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Oct 5, 2021

@gombosg , @avinal
What do you think about adding this kind of note?

This may be useful for wayland+flatpak/wayland+appimage users.

I have described full workaround here: https://github.com/AntiMicroX/antimicrox/wiki/Open-uinput-error

TODO: make link clickabel

@pktiuk pktiuk requested a review from gombosg October 5, 2021 15:44
@pktiuk
Copy link
Member Author

pktiuk commented Oct 5, 2021

Maybe just printing this error in console would be less intrusive than popup, but casual users could easily miss it.
IDK
What do you think?

@gombosg
Copy link
Collaborator

gombosg commented Oct 24, 2021

Well, flatpak can't use uinput, right? What is the drawback of that? (Using xtest) On Wayland only uinput works?

@pktiuk
Copy link
Member Author

pktiuk commented Oct 24, 2021

Well, flatpak can't use uinput, right? What is the drawback of that? (Using xtest) On Wayland only uinput works?

Yes, but there is a workaround in wiki site mentioned above.

You just need to manually download udev rule (udev rules can't be applied by flatpak packages this is also the case with AppImage)

@pktiuk pktiuk requested a review from avinal October 25, 2021 18:10
@pktiuk
Copy link
Member Author

pktiuk commented Oct 27, 2021

@avinal
What do you think about this way of telling users about problem and informing them about possible workaround?

Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay, I was very busy. I think this particular problem is common and displaying a pop-up is a nice way to inform the workaround. But if we already know about problems we should try to fix this completely. That could be our next step.

Other than that it seems okay to me.

@pktiuk pktiuk force-pushed the note_about_uinput_problems branch from 7cfd0ae to 56cca21 Compare November 6, 2021 21:43
@pktiuk
Copy link
Member Author

pktiuk commented Nov 6, 2021

This is how this message looks like:

obraz

@pktiuk pktiuk force-pushed the note_about_uinput_problems branch from 56cca21 to b8e2de6 Compare November 6, 2021 21:49
@pktiuk pktiuk merged commit c096734 into master Nov 6, 2021
@pktiuk pktiuk deleted the note_about_uinput_problems branch November 6, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants