Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use system icons in common cases to avoid incompatibility issues #62

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Fix: Use system icons in common cases to avoid incompatibility issues #62

merged 3 commits into from
Oct 13, 2020

Conversation

pktiuk
Copy link
Member

@pktiuk pktiuk commented Oct 12, 2020 •
edited
Loading

Part of #61
Fix #56
It should also help with #58

Proposed changes

  • Usage of default (provided by system) icons in place of all icons with existing counterparts.

@pktiuk
Copy link
Member Author

pktiuk commented Oct 12, 2020

Works well with Ubuntu.
@gombosg
Could you tell me how it works with other configs?

@pktiuk pktiuk linked an issue Oct 12, 2020 that may be closed by this pull request
Icons overhaul #61
Closed
5 tasks
@pktiuk pktiuk removed a link to an issue Oct 12, 2020
Icons overhaul #61
Closed
5 tasks
gombosg
gombosg approved these changes Oct 13, 2020
View reviewed changes
Copy link
Collaborator

@gombosg gombosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and works fine for me, compiled locally and Flatpak too.

@pktiuk pktiuk linked an issue Oct 13, 2020 that may be closed by this pull request
AntiMicroX system tray icon not appearing in flatpak package #58
Closed
@pktiuk pktiuk merged commit eb10489 into master Oct 13, 2020
@pktiuk pktiuk deleted the use_system_icons branch October 13, 2020 09:07
@pktiuk pktiuk mentioned this pull request Oct 26, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gombosg gombosg gombosg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AntiMicroX system tray icon not appearing in flatpak package Icons in tray menu only showing up as "X"
2 participants
@pktiuk @gombosg