fix: Replace SDL controller calls with joystick ones in Joystick.
#665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pktiuk
reviewed
Dec 17, 2022
pktiuk
requested changes
Dec 17, 2022
This is enough of a fix to resolve the issue in AntiMicroX#632, but there are a few other edge cases that investigation brought up that may cause a similar issue in the future.
nitz
force-pushed
the
fix-joystick-unique-id-generation-win11
branch
from
551ea6d to
1841e37
Compare
|
Ah! I didn't catch the minimum version in cmakelists; perfect. I amended that commit to remove the 2.0.6 checks! |
|
Thank you for your contribution and feel free to create new PR-s :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #632
Proposed changes
This is enough of a fix to resolve the issue in #632, but there are a few other edge cases that investigation brought up that may cause a similar issue in the future.
Joystickwas using calls toSDK_GameController(*)functions. On Windows 11 at least, theSDK_Controller*returned fromSDL_GameControllerOpeninJoystick's constructor was null, causing the unique ID building to be quite sparse. Thus, the Joystick's guid would match it's unique ID, causing profiles to fail to load automatically on startup. These changes resolve that, though some other oddities outlined in my comment in #632 do still persist.