Statically link our code #99

AriaMoradi · 2020-11-29T22:16:58Z

Closes #98

~~Might fail for the 'deb' target. I'm not sure...~~

~~Since this is mostly a search-and-replace job, things should not break, though it might break some install scripts...~~

CMakeLists.txt

gombosg · 2020-11-29T22:52:44Z

See my comment at the corresponding bug.

AriaMoradi · 2020-11-29T23:58:51Z

So, building without a shared object was successful but for some reason I had to add X11::xcb manually because the linker was complaining about it, but the linker didn't ask for it before..

AriaMoradi · 2020-11-30T00:07:10Z

and now CI build is failing because It doesn't have xcb!
Well I'm confused.

if you ask me we always did need it, it's included in qglobalshortcut.cc!
And I'm more confused.

gombosg

Nice job, builds and runs though the pipeline has to be fixed before a merge.

CMakeLists.txt

gombosg · 2020-11-30T08:46:20Z

CMakeLists.txt



-            add_executable(antimicrox ${antimicrox_MAIN})
-            target_link_libraries (antimicrox antilib Qt5::Widgets Qt5::Core Qt5::Gui Qt5::Network Qt5::Concurrent)
+        target_link_libraries(antimicrox Qt5::Widgets Qt5::Core Qt5::Gui Qt5::Network Qt5::Concurrent ${LIBS})


Where's ${SDL_LIBRARY}? Maybe that contained xcb?

pkg_check_modules(XXX REQUIRED yyy) provides XXX_LIBRARIES which in the case is SDL2_LIBRARIES

this is a oddity in the ways we find libraries.
we could just use find_package(SDL2 REQUIRED) which provides SDL_LIBRARIES and SDL_LIBRARY(they are the same).

So i think in a previous version we used find_package but later it was changed to pkg_check_modules but they forgot to remove the variable.(I can't think of any reasons other than older cmake versions behaving differently)

anyways, I could refactor further and bring back find_package?

ref: https://cmake.org/cmake/help/latest/module/FindSDL.html
ref: https://cmake.org/cmake/help/latest/module/FindPkgConfig.html

and before my changes it was empty(not set) so removing it wont change anything.

gombosg · 2020-11-30T08:49:39Z

Sorry, I found SDL at an earlier append_libs. (Then why was it duplicated before?)

gombosg · 2020-11-30T09:00:57Z

CMakeLists.txt

-        endif()
-
-            add_library( antilib
-                SHARED


I have a suspicion that xcb linking was not needed because this used to be compiled as a shared library, it was only linked dynamically, and xcb is a requirement for qt so it's available at runtime. @pktiuk is this a wild guess?

We directly need xcb because some functions fro xcb/xcb.h where used.
And these are not a part of qt in any ways possible..

gombosg · 2020-11-30T11:35:51Z

It's nice, but we need green ✔️ to merge. So that problem needs to be sorted out first somehow.

AriaMoradi · 2020-11-30T12:05:54Z

It's nice, but we need green to merge. So that problem needs to be sorted out first somehow.

another pull request should add xcb to the build script

AriaMoradi · 2020-11-30T14:04:31Z

another pull request should add xcb to the build script

I've tried various settings and configs but I cant get github actions to build on my fork

[100%] Building CXX object CMakeFiles/antimicrox.dir/qrc_resources.cpp.o
[100%] Linking CXX executable bin/antimicrox
/usr/bin/ld: CMakeFiles/antimicrox.dir/src/qglobalshortcut/qglobalshortcut.cc.o: undefined reference to symbol 'xcb_grab_key'
//usr/lib/x86_64-linux-gnu/libxcb.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [bin/antimicrox] Error 1
CMakeFiles/antimicrox.dir/build.make:4374: recipe for target 'bin/antimicrox' failed
CMakeFiles/Makefile2:153: recipe for target 'CMakeFiles/antimicrox.dir/all' failed
Makefile:168: recipe for target 'all' failed
make[1]: *** [CMakeFiles/antimicrox.dir/all] Error 2
make: *** [all] Error 2

I suspect that I'm not installing the currect packages.

I added two lines to inspect the X11_xcb_LIB variable, on my system it has a value:

-- Found X11 Xkb: /usr/lib/libxkbfile.so
-- Found X11 Xkb: /usr/lib/libxcb.so

but under ubuntu

-- Found X11 Xkb: /usr/lib/x86_64-linux-gnu/libxkbfile.so
-- Found X11 Xkb:

AriaMoradi · 2020-11-30T14:10:52Z

I've verified that /usr/lib/x86_64-linux-gnu/libxcb.so.1 exists on the gh actions vm but cmake wont find it?

gombosg · 2020-11-30T19:10:03Z

@pktiuk save us! :D

AriaMoradi · 2020-11-30T20:32:56Z

@pktiuk save us! :D

He might not be available for the time being, we have to figure this ourselfs.
Well I tried over a dozen of configs and possible solutions on my fork and non worked.
I'll try debugging cmake later.

AriaMoradi · 2020-11-30T20:33:22Z

@gombosg can you build my PR on your end?

pktiuk · 2020-11-30T20:43:42Z

I won't be able to look at this during this week, but I think this change can (and should) just wait.
It isn't any bugfix or feature and it is invisible change for end-users.

gombosg · 2020-12-01T23:24:41Z

I spent way too much time on this already. I have no clue what's going on. Tried linking against X11_xcb, XCB, X11_X11_xcb etc.
Only X11_xcb === X11::xcb is good, but it doesn't run on the VM.

Tried updating to ubuntu-20.04, tried adding xcb libxcb1-dev to installed packages, they didn't help.

I even checked the pkgconfig files on Ubuntu repos and my machine and they are the same. So I give up.

Next step is removing qglobalshortcuts in a separate PR.

only 1 small functionality tied to it (quit app shortcut - not really useful)
unlicensed, see Missing explicit copyright licence mitei/qglobalshortcut#1
allows doing this PR which is important for Debian packaging

#106

pktiuk · 2020-12-02T00:15:34Z

Sorry you had to wait for me, but yesterday I had an exam and today I was preparing for the next tomorrow xD

I have dealt with this problem in another PR #107

This one can be closed.

Testing

library: rename and remove version number

2e30687

AriaMoradi requested review from pktiuk and gombosg and removed request for pktiuk November 29, 2020 22:17

AriaMoradi commented Nov 29, 2020

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

AriaMoradi added 2 commits November 30, 2020 01:55

fix possible deb error

514836b

remove redundant text

669743b

remove the shared library

6eab89d

AriaMoradi changed the title ~~library: rename and remove version number~~ Statically link our code Nov 30, 2020

gombosg reviewed Nov 30, 2020

View reviewed changes

AriaMoradi added 3 commits November 30, 2020 12:38

reformat the file

6af3667

refactor and cleanup libs

e0fe8ad

merge master into so_rename

4878f72

AriaMoradi requested a review from gombosg November 30, 2020 11:08

gombosg mentioned this pull request Dec 1, 2020

Migrate DEB packages to antimicrox #87

Closed

2 tasks

gombosg mentioned this pull request Dec 1, 2020

Cmakefile fixes #102

Closed

2 tasks

try X11 XCB

a9f14b0

gombosg mentioned this pull request Dec 1, 2020

Remove qglobalshortcuts #106

Closed

pktiuk mentioned this pull request Dec 2, 2020

Remove antilib from building targets #107

Merged

pktiuk closed this in #107 Dec 2, 2020

AriaMoradi deleted the so_rename branch December 2, 2020 15:25

Gallxz pushed a commit to Gallxz/antimicrox that referenced this pull request Oct 12, 2023

Merge pull request AntiMicroX#99 from juliagoda/testing

ee0df1e

Testing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Statically link our code #99

Statically link our code #99

AriaMoradi commented Nov 29, 2020 •

edited

Loading

gombosg commented Nov 29, 2020

AriaMoradi commented Nov 29, 2020

AriaMoradi commented Nov 30, 2020

gombosg left a comment

gombosg Nov 30, 2020

AriaMoradi Nov 30, 2020 •

edited

Loading

AriaMoradi Nov 30, 2020 •

edited

Loading

gombosg commented Nov 30, 2020

gombosg Nov 30, 2020 •

edited

Loading

AriaMoradi Nov 30, 2020 •

edited

Loading

gombosg commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020 •

edited

Loading

AriaMoradi commented Nov 30, 2020 •

edited

Loading

AriaMoradi commented Nov 30, 2020

gombosg commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020

pktiuk commented Nov 30, 2020

gombosg commented Dec 1, 2020

pktiuk commented Dec 2, 2020

Statically link our code #99

Statically link our code #99

Conversation

AriaMoradi commented Nov 29, 2020 • edited Loading

gombosg commented Nov 29, 2020

AriaMoradi commented Nov 29, 2020

AriaMoradi commented Nov 30, 2020

gombosg left a comment

Choose a reason for hiding this comment

gombosg Nov 30, 2020

Choose a reason for hiding this comment

AriaMoradi Nov 30, 2020 • edited Loading

Choose a reason for hiding this comment

AriaMoradi Nov 30, 2020 • edited Loading

Choose a reason for hiding this comment

gombosg commented Nov 30, 2020

gombosg Nov 30, 2020 • edited Loading

Choose a reason for hiding this comment

AriaMoradi Nov 30, 2020 • edited Loading

Choose a reason for hiding this comment

gombosg commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020 • edited Loading

AriaMoradi commented Nov 30, 2020 • edited Loading

AriaMoradi commented Nov 30, 2020

gombosg commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020

AriaMoradi commented Nov 30, 2020

pktiuk commented Nov 30, 2020

gombosg commented Dec 1, 2020

pktiuk commented Dec 2, 2020

AriaMoradi commented Nov 29, 2020 •

edited

Loading

AriaMoradi Nov 30, 2020 •

edited

Loading

AriaMoradi Nov 30, 2020 •

edited

Loading

gombosg Nov 30, 2020 •

edited

Loading

AriaMoradi Nov 30, 2020 •

edited

Loading

AriaMoradi commented Nov 30, 2020 •

edited

Loading

AriaMoradi commented Nov 30, 2020 •

edited

Loading