Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translation): Add missing translations for WARNING and ERROR #194

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Jul 4, 2024

Description

The "WARNING" and "ERROR" words (used when printing a warning or an error messages to users) were missing from the translations files and were thus printed as such whatever language is used.

Screenshots / Logs

Before the fix:
image

After the fix:
image

Fixed bug

Fixes #182

Antiz96 added 2 commits July 4, 2024 12:21
The "WARNING" and "ERROR" words (used when printing a warning or an error messages to users) were missing from the translations files and were thus printed as such whatever language is used.

Fixes #182
Addresses shellcheck SC2027
@Antiz96 Antiz96 added this to the v2.2.0 milestone Jul 4, 2024
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 3e5c8f6 into main Jul 4, 2024
1 check passed
@Antiz96 Antiz96 deleted the fr_translations branch July 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The WARNING and ERROR prefix messages are missing from the french translation
1 participant