Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix False Positive for Unused Runtimes when Flatpak has Runtimes Pinned #286

Merged
merged 2 commits into from
Dec 4, 2024
+2 −2
Merged

Fix False Positive for Unused Runtimes when Flatpak has Runtimes Pinned #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12384ba
fix: false positive on unused runtimes for Flatpak with pinned runtimes
RayJW Dec 4, 2024
5ed5653
chore: use uninstall instead of the alias remove for Flatpak
RayJW Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/orphan_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
orphan_packages=$(pacman -Qtdq)

if [ -n "${flatpak}" ]; then
flatpak_unused=$(flatpak remove --unused | awk '{print $2}' | grep -v '^$' | sed '$d')
flatpak_unused=$(flatpak uninstall --unused | sed -n '/^ 1./,$p' | awk '{print $2}' | grep -v '^$' | sed '$d')
fi

if [ -n "${orphan_packages}" ]; then
Expand Down Expand Up @@ -60,7 +60,7 @@ if [ -n "${flatpak}" ]; then
echo
main_msg "$(eval_gettext "Removing Flatpak Unused Packages...")"

if ! flatpak remove --unused; then
if ! flatpak uninstall --unused; then
echo
error_msg "$(eval_gettext "An error has occurred during the removal process\nThe removal has been aborted\n")"
else
Expand Down