is-23: polynomials viewed as operators #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added implementation of linear_operator_ring for RingWithOperators_Wrapper Added conversion from a RingWithOperators_Wrapper to its ring of linear operators.
Added conversion from "RWOPolynomialRing_dense" to the ring of linear operators. Added the conversion from the ring of linear operators to "RWOPolynomialRing_dense" Added method "as_linear_operator" that transforms RWOPolynomials to the corresponding (possible) linear operator. Also added that method in the RWOPolynomial.
_element_constructor_ for RWOPolynomialRing_dense works better in the case of linear operators. It distinguish betwenn univariate and multivariate polynomial interfaces Added explanation on "eval" about the composition of operators. Added tests to check this functionality Fixed error when evaluating expressions. Added documentation and tests for "as_linear_operator". Fixed error when having only one operator.
Fixed RWOPolyRingFunctor, now it has a rank and a merge function to merge difference RWOPolyRingFunctor functors
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will merge the changes necessary to close #23.
In this issue we have address the problem of seeing the operator polynomials in
RWOPolynomialas operators. In the linear case, we should be able to transform these into objects in the packageore_algebraand in the non-linear case we are able to compose operators using evaluation.